Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move config path generation into the service config for reusability #3978

Merged
merged 8 commits into from
Nov 1, 2019
Merged

Move config path generation into the service config for reusability #3978

merged 8 commits into from
Nov 1, 2019

Commits on Oct 31, 2019

  1. Move config path generation into the service config for reusability

    @gnunicorn
    gnunicorn committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    4ecbc2b View commit details
    Browse the repository at this point in the history

  2. Make NoCostum Default and fix tests

    @gnunicorn
    gnunicorn committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    fc9f1b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Bastian Köcher <[email protected]>
    @gnunicorn @bkchr
    gnunicorn and bkchr authored Nov 1, 2019
    Configuration menu
    Copy the full SHA
    8a1a25d View commit details
    Browse the repository at this point in the history

  2. remove function not used anymore

    @gnunicorn
    gnunicorn committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    3f12f75 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into ben-make-config-pat… 

    …h-usage-reusable-for-services
    @gnunicorn
    gnunicorn committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    7be8cbf View commit details
    Browse the repository at this point in the history

  4. Make path into an option

    @gnunicorn
    gnunicorn committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    0113741 View commit details
    Browse the repository at this point in the history

  5. remove database_path function and call it directly

    @gnunicorn
    gnunicorn committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e31e204 View commit details
    Browse the repository at this point in the history

  6. remove helper functions, use consts

    @gnunicorn
    gnunicorn committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    bd0f5de View commit details
    Browse the repository at this point in the history