This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce 128-bit shim for u128/i128 and use it for Balance #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
May 16, 2018
| impl_as!($f, $i: u8, u16, u32, u64, u128, usize, i8, i16, i32, i64, i128, isize); | ||
| }; | ||
| ( $f:ident, $i:ty : $t:ty $(, $rest:ty)* ) => { | ||
| impl As<$t> for $f { |
There was a problem hiding this comment.
why not just From and Into?
There was a problem hiding this comment.
It's designed to work to convert between all numerics; From/Into don't do that. (try compiling fn main() -> u8 { 69u32.into() } on playground.)
There was a problem hiding this comment.
Still, this As trait is just From + Into, isn't it?
There was a problem hiding this comment.
Well, it is used a bit like From and Into. But in terms of what it does, it can convert between numeric types like the as keyword. From and Into can't be implemented to convert between numeric types.
There was a problem hiding this comment.
so it's just an escape hatch around the orphan rules for primitives? it could be that TryFrom/TryInto will be implemented for all pairs in the future.
rphmeier
approved these changes
May 23, 2018
arkpar
added
A8-looksgood
and removed
A0-please_review
arkpar
approved these changes
May 24, 2018
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* move balances&transaction-payment into chainx * fix assets * fix gateway * fix xcontracts * add transfer_with_memo in pallet-balances * add debug in pallet-transaction-payment * fix bug for `TotalAssetBalance` * add assets test * Balances migration for Mining and DEX (paritytech#162) * Add sketch of generic-reserves * Introduce NativeReservedType * Add move_reserved_asset() * Only record NativeReservedType in generic-reserves * Change storage item name to NativeReserves * Replace xpallet_assets with Currency * Impl Staking issue and move_balance * LockableCurrency is required * Test mint_should_work() * Impl bond_reserve() * Finish balances migration for Staking * Remove xpallet-assets in Staking * Replace T::Balance with BalanceOf<T> in DEX * Impl native reserves * Pass partial DEX tests * Do not silence the asset error * Curreny in assets has be Reserable and Lockable * Use Currency from assets if neccesary * Migrate mining/asset * Add StakingInterface in mining/asset * Fix a fatal storage naming error * Pass mining/asset tests * Pass DEX tests * Fix runtime migration * Fix balances genesis The balances has duplicated items which are problematic. * finish xassets tests * add doc for rpc Co-authored-by: Liu-Cheng Xu <[email protected]>
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Revert contracts put_code test to pure code (not using the macro) * Test contract instantiate * Fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ice until after we tag poc-1.