This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Commit-reveal based solution submission for EPM #13129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
A3-in_progress
github-actions
bot
added
A0-please_review
|
The CI pipeline was cancelled due to failure one of the required jobs. |
the-right-joyce
added
B1-note_worthy
Ank4n
reviewed
Mar 4, 2023
| Signed, | ||
| /// Umbrella phase for all the commit-reveal phases (i.e `Commit`, `Reveal` and | ||
| /// `FallbackReveal`). | ||
| CommitReveal, |
There was a problem hiding this comment.
Would a nested enum be more appropriate?
Then the enums could look like
pub enum Phase {
Off,
CommitReveal(CommitReveal),
Signed,
Unsigned((bool, Bn)),
Emergency,
}
pub enum CommitReveal {
Commit,
Reveal((AccountId, Bn)),
FallbackReveal
}
Ank4n
reviewed
Mar 4, 2023
|
|
||
| /// Duration of the commit reveal phase. | ||
| #[pallet::constant] | ||
| type CommitReveal: Get<Self::BlockNumber>; |
There was a problem hiding this comment.
I know this was how the phase durations were named before. But I feel it would be better if we name these associated types as CommitRevealDuration, CommitPhaseDuration and so on. Wdyt?
Ank4n
reviewed
Mar 4, 2023
| /// | ||
| /// Stores a bounded set of `ElectionScore`, indexed by the score. | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn commitments)] |
kianenigma
added
A3-in_progress
|
I'm closing this PR since I do not intend to work on it any time soon, but let's keep an eye on paritytech/polkadot-sdk#457 and revisit/re-open this PR when useful. |
louismerlin
removed
the
D9-needsaudit 👮
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs (wip): https://hackmd.io/zE1goNRmSsa8q_LCjHD5Kg
Currently, the EPM signed expects staking miners to submit a full election solution, which is expensive (tx-fees) and potentially stores a lot of redundant data on-chain. This PR splits the solution submission into two phases:
Closes paritytech/polkadot-sdk#457