This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Clarify the "direction" field of block requests #12438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A2-insubstantial
This was referenced Oct 6, 2022
Closed
bkchr
approved these changes
Oct 7, 2022
|
Yes As I mention, we never actually send the "direction" field when we mean "Ascending". |
arkpar
approved these changes
Oct 7, 2022
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for d5fd2c4 |
|
bot merge |
|
Waiting for commit status. |
19 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered a stupidity: when we send a block request, the "direction" field (i.e. is the starting block of the request the highest block or the lowest block) is either 0 or 1.
However, the protobuf library that we use can't make the difference between "missing field" and "field that contains a 0".
So whenever we send an "ascending" block request, we are in fact not indicating any direction.
For this reason, I'm opening this PR to clarify that the default value should be interpreted as "Ascending".
It could instead be fixable by releasing a version that also interprets "2" as "Ascending", then later a version that sends "2" for "Ascending", but I don't think it's worth the effort.