Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Backport #11807 #11811

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Backport #11807 #11811

merged 1 commit into from
Jul 12, 2022

Conversation

shawntabrizi
Copy link
Member

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 10, 2022
@shawntabrizi shawntabrizi added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 10, 2022
coderobe
coderobe suggested changes Jul 10, 2022
View reviewed changes
Copy link

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.25 is already released, we are currently working on .26 - if this really cannot wait for .27, could you retarget this for .26 instead?

@shawntabrizi
Copy link
Member Author

@coderobe if you look at the original PR, a user is asking for this to be on 0.9.25, so... doing this for them, not for me.

@shawntabrizi shawntabrizi changed the base branch from polkadot-v0.9.25 to polkadot-v0.9.26 July 10, 2022 14:42
@shawntabrizi shawntabrizi requested a review from athei as a code owner July 10, 2022 14:42
@shawntabrizi
BACKPORT: Un-deprecate Transactional Macro (#11807)
ccadc94 
* un-deprecate transactional macro

* add transactional back to nomination pools
@shawntabrizi shawntabrizi force-pushed the shawntabrizi-backport-transactional-signed branch from 1aa78e6 to ccadc94 Compare July 10, 2022 14:46
@shawntabrizi shawntabrizi requested a review from coderobe July 10, 2022 14:48
@coderobe coderobe merged commit 76c82c7 into polkadot-v0.9.26 Jul 12, 2022
@coderobe coderobe deleted the shawntabrizi-backport-transactional-signed branch July 12, 2022 08:14
@librelois librelois mentioned this pull request Jul 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderobe coderobe coderobe approved these changes

@kianenigma kianenigma kianenigma approved these changes

@athei athei Awaiting requested review from athei

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawntabrizi @kianenigma @coderobe