This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method.
gilescope
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Apr 22, 2022
andresilva
approved these changes
Apr 22, 2022
ggwpez
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not work for me…
$ nix-shell --run "cargo check --workspace --all-targets --all-features"
error[E0428]: the name `can_build_child_tree` is defined multiple times
--> utils/frame/remote-externalities/src/lib.rs:1195:8
|
1102 | async fn can_build_child_tree() {
| ------------------------- previous definition of the value `can_build_child_tree` here
...
1195 | async fn can_build_child_tree() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ `can_build_child_tree` redefined here
|
= note: `can_build_child_tree` must be defined only once in the value namespace of this module
Checking beefy-gadget v4.0.0-dev (/home/vados/substrate/client/beefy)
warning: unused import: `std::env`
--> frame/support/test/tests/construct_runtime_ui.rs:18:5
|
18 | use std::env;
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: `frame-support-test` (test "construct_runtime_ui") generated 1 warning
For more information about this error, try `rustc --explain E0428`.
error: could not compile `remote-externalities` due to previous error
warning: build failed, waiting for other jobs to finish...
A CI check would help to spot these regressions.
Good spot. That test is unlikely to pass on anyone else's machine than his. I don't think he intended to commit that version. I've removed it. |
It somehow still fails… I will open a CI ticket, maybe we can get a check?
|
ggwpez
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI check says its fine now, so should be good.
bkchr
approved these changes
Apr 27, 2022
bot merge |
1 similar comment
bot merge |
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jun 8, 2022
* wip: upgrade to Polkadot v0.9.22 * wip: upgrade to Polkadot v0.9.23 * fix: remove deprecated migrations NOTE: StorageVersion is tracked inside pallet macro * fix: fee calc paritytech/substrate#11415 * chore: bump deps * fix: add missing check for non zero sender paritytech/substrate#10413 * fix: client changes * refactor: downgrade nightly paritytech/substrate#11266 * chore: upgrade to latest nightly supported by Substrate * fix: clippy * fix: clippy * ci: bump srtool to 1.60 * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs * fix: rilt spec * fix: remove wip unused file * chore: bump deps Co-authored-by: kiltbot <>
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* The 2022-02-10 nightly can't build some deps There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method. * removing duplicate test * [ci] add job cargo-check-nixos * add dummy variables nix check * fix check-dependent jobs * fix check-dependent-project template Co-authored-by: alvicsam <[email protected]>
ntn-x2
pushed a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jun 23, 2022
* wip: upgrade to Polkadot v0.9.22 * wip: upgrade to Polkadot v0.9.23 * fix: remove deprecated migrations NOTE: StorageVersion is tracked inside pallet macro * fix: fee calc paritytech/substrate#11415 * chore: bump deps * fix: add missing check for non zero sender paritytech/substrate#10413 * fix: client changes * refactor: downgrade nightly paritytech/substrate#11266 * chore: upgrade to latest nightly supported by Substrate * fix: clippy * fix: clippy * ci: bump srtool to 1.60 * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs * fix: rilt spec * fix: remove wip unused file * chore: bump deps Co-authored-by: kiltbot <> (cherry picked from commit 5e2fec6)
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* The 2022-02-10 nightly can't build some deps There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method. * removing duplicate test * [ci] add job cargo-check-nixos * add dummy variables nix check * fix check-dependent jobs * fix check-dependent-project template Co-authored-by: alvicsam <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* The 2022-02-10 nightly can't build some deps There's a sig that returns `impl IntoIterator<Item = (&'static str, OsString)>` and an Option is being retured but it's incorrectly not allowing a `?` in the method. * removing duplicate test * [ci] add job cargo-check-nixos * add dummy variables nix check * fix check-dependent jobs * fix check-dependent-project template Co-authored-by: alvicsam <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2022-02-10 nightly can't build a dep we're pulling in:
There's a sig that returns
impl IntoIterator<Item = (&'static str, OsString)>
and an Option is being returned as the concrete implementation of the iterator but it's incorrectly not allowing a?
in the method.