This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove some last AccountId32::default() leftovers
#10655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we removed `Default` of account id, we have overseen some last bits. This pr removes these last bits.
bkchr
added
A0-please_review
shawntabrizi
approved these changes
Jan 14, 2022
KiChjang
approved these changes
Jan 14, 2022
kianenigma
approved these changes
Jan 14, 2022
KiChjang
added
A7-needspolkadotpr
and removed
A0-please_review
|
Needs cumulus and polkadot companions, sadly. |
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Jan 21, 2022
paritytech/substrate#10655 This removes the last usages of `Default` in conjunction with `AccountId`
paritytech-processbot bot
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Jan 21, 2022
* Companion for Substrate#10655 paritytech/substrate#10655 This removes the last usages of `Default` in conjunction with `AccountId` * More fixes * More of them! * FMT * Update Substrate
eskimor
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Remove some last `AccountId32::default()` leftovers As we removed `Default` of account id, we have overseen some last bits. This pr removes these last bits. * Fix
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* Companion for Substrate#10655 paritytech/substrate#10655 This removes the last usages of `Default` in conjunction with `AccountId` * More fixes * More of them! * FMT * Update Substrate
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* Remove some last `AccountId32::default()` leftovers As we removed `Default` of account id, we have overseen some last bits. This pr removes these last bits. * Fix
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Remove some last `AccountId32::default()` leftovers As we removed `Default` of account id, we have overseen some last bits. This pr removes these last bits. * Fix
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Remove some last `AccountId32::default()` leftovers As we removed `Default` of account id, we have overseen some last bits. This pr removes these last bits. * Fix
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Mar 10, 2023
* Companion for Substrate#10655 paritytech/substrate#10655 This removes the last usages of `Default` in conjunction with `AccountId` * More fixes * More of them! * FMT * Update Substrate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we removed
Defaultof account id, we have overseen some last bits. This pr removes these lastbits.
polkadot companion: paritytech/polkadot#4765