This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Get rid of the dreaded Other error
#10595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
HCastano
approved these changes
Jan 5, 2022
cmichi
approved these changes
Jan 17, 2022
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Print more detailed error when instrumentation fails * Apply suggestions from code review Co-authored-by: Hernando Castano <[email protected]> * Check contents of debug buffer * Fix test Co-authored-by: Hernando Castano <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Print more detailed error when instrumentation fails * Apply suggestions from code review Co-authored-by: Hernando Castano <[email protected]> * Check contents of debug buffer * Fix test Co-authored-by: Hernando Castano <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the dreaded
Othererror by aCodeRejectederror. This is the last occurrence of an error that isn't translated into a module specific error. It also prints a more detailed information on why it was rejected to the debug buffer (if only someone would inspect this buffer) and to the node console.