This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Improve documentation of lazy deletion config #10582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
athei
force-pushed
the
at-contract-docs
branch
from
6864f43 to
c644a41
Compare
sacha-l
reviewed
Jan 4, 2022
Co-authored-by: Sacha Lansky <[email protected]>
ascjones
approved these changes
Jan 5, 2022
frame/contracts/src/lib.rs
Outdated
| @@ -255,10 +255,29 @@ pub mod pallet { | |||
| type CallStack: smallvec::Array<Item = Frame<Self>>; | |||
|
|
|||
| /// The maximum number of tries that can be queued for deletion. | |||
There was a problem hiding this comment.
Slightly ambiguous as "tries" could possibly be interpreted as "attempts" on first reading. Maybe fully qualify e.g. "contract storage tries"
There was a problem hiding this comment.
Good point. Changed the wording.
Co-authored-by: Andrew Jones <[email protected]>
HCastano
approved these changes
Jan 5, 2022
|
bot merge |
|
Waiting for commit status. |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…10582) * Improve documentation of lazy deletion config * Apply suggestions from code review Co-authored-by: Sacha Lansky <[email protected]> * Update frame/contracts/src/lib.rs Co-authored-by: Andrew Jones <[email protected]> * Improve wording Co-authored-by: Sacha Lansky <[email protected]> Co-authored-by: Andrew Jones <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…10582) * Improve documentation of lazy deletion config * Apply suggestions from code review Co-authored-by: Sacha Lansky <[email protected]> * Update frame/contracts/src/lib.rs Co-authored-by: Andrew Jones <[email protected]> * Improve wording Co-authored-by: Sacha Lansky <[email protected]> Co-authored-by: Andrew Jones <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added some better documentation for two items after receiving some questions about them.