Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve SS58 related errors #10541

Merged
merged 6 commits into from
Dec 25, 2021
Merged

Improve SS58 related errors #10541

merged 6 commits into from
Dec 25, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 22, 2021

This improves the SS58 error, especially when it comes to parsing public keys with unknown SS58
address formats.

This improves the SS58 error, especially when it comes to parsing public keys with unknown SS58
address formats.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 22, 2021
@bkchr
Copy link
Member Author

bkchr commented Dec 25, 2021

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit 82d87bc into master Dec 25, 2021
@paritytech-processbot paritytech-processbot bot deleted the bkchr-improve-ss58 branch December 25, 2021 07:19
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Improve SS58 related errors

This improves the SS58 error, especially when it comes to parsing public keys with unknown SS58
address formats.

* Make CI happy

* More fixes

* More

* 🤦

* fml...
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Improve SS58 related errors

This improves the SS58 error, especially when it comes to parsing public keys with unknown SS58
address formats.

* Make CI happy

* More fixes

* More

* 🤦

* fml...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants