Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use exists host function for child tries #10531

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

athei
Copy link
Member

@athei athei commented Dec 21, 2021

frame_support::storage::child::exists was using the read host function when the exists host function is the better fit.

Please note that this should not yield any substantial performance benefit because the substrate client does read the complete contents of the stored value from storage in both cases.

@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Dec 21, 2021
@athei athei requested review from cheme and bkchr December 21, 2021 16:18
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exists is indeed a better fit

@bkchr bkchr merged commit 3ce158c into master Dec 21, 2021
@bkchr bkchr deleted the at-fix-child-contains branch December 21, 2021 17:36
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants