Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[ci] Fix publish-rustdoc #10364

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[ci] Fix publish-rustdoc #10364

merged 1 commit into from
Nov 24, 2021

Conversation

alvicsam
Copy link
Contributor

Removed - rm -rf /tmp/* from .gitlab-ci.yml (in publish-rustdocs job) because it breaks ssh-agent. Also it's not needed because /tmp is empty when container initialised.

@alvicsam alvicsam added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 24, 2021
@alvicsam alvicsam requested review from rcny, TriplEight, sergejparity and a team November 24, 2021 11:30
@TriplEight
Copy link
Contributor

TriplEight commented Nov 24, 2021

This was a precaution for gitlab's known issue that it can reuse the container from the other job. And it only takes care about cleaning the working dir. cc @rcny

@alvicsam
Copy link
Contributor Author

@TriplEight should I revert changes back? As they were before #10338

@rcny
Copy link
Contributor

rcny commented Nov 24, 2021

reuse the container from the other job

AFAIK GitLab reuses project's local working copy with GIT_STRATEGY: fetch, which can result in e.g. a different view what current master is for different runner instances. Never heard about containers reuse.

@alvicsam alvicsam merged commit c519f0f into master Nov 24, 2021
@alvicsam alvicsam deleted the as-fix-ci-publish-docs branch November 24, 2021 15:00
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants