-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add pallet names to Events #10296
Add pallet names to Events #10296
Conversation
Okay @athei. |
CI is not making any damn sense to me, I've restarted it multiple times but it still errors on the event types on the companion PR, but then the companion PR CI is all passing! I've no idea what's going on here, it's all arcane magic to me. cc @paritytech/ci |
bot merge |
Error: Response error (status 404 Not Found):
|
bot merge force |
Error: Response error (status 404 Not Found):
|
bot merge |
Error: Response error (status 404 Not Found):
|
Hi @bkchr, Hope you are having a great day, please do you know why this error occurs |
bot merge |
Error: Github API says paritytech/polkadot#4339 is not mergeable |
bot merge |
Error: Response error (status 404 Not Found):
|
/tip medium |
1 similar comment
/tip medium |
A medium tip was successfully submitted for ECJ222 (13g44iYtkxLZ2tkp6iTJiqs7yEiEr4bVsPZTueWDjd6Bor1P on polkadot). |
* chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * fix: add fix to tests for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: updated transaction-storage pallet event variants * chore: updated transaction-storage pallet event variants * chore: formatted contracts pallet * chore: update treasury event variants
* chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: add pallet names to events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * chore: formatted pallet name changes in events * fix: add fix to tests for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified comments for event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: modified system pallet event variants * chore: updated transaction-storage pallet event variants * chore: updated transaction-storage pallet event variants * chore: formatted contracts pallet * chore: update treasury event variants
This PR changes the pallet events variants from tuples to structs with named fields
Part implementation for #9903, #9993, #10184, #10206, #10257
Pallets with changes
I also made a few changes to the following pallets after I changed the pallet events variants from tuples to structs with named fields in the
system
pallet. i.e NewAccount, KilledAccount, Remarked.polkadot companion: paritytech/polkadot#4339
Polkadot address: 13g44iYtkxLZ2tkp6iTJiqs7yEiEr4bVsPZTueWDjd6Bor1P