Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Warn about usage of pallet collective set members call. #10156

Merged
merged 3 commits into from
Nov 11, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frame/collective/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,13 @@ pub mod pallet {
/// NOTE: Does not enforce the expected `MaxMembers` limit on the amount of members, but
/// the weight estimations rely on it to estimate dispatchable weight.
///
/// # WARNING:
///
/// The pallet collective can also be managed by logic outside of the pallet throught the
gui1117 marked this conversation as resolved.
Show resolved Hide resolved
/// implementation of the trait [`ChangeMembers`].
/// Any call to `set_members` must be careful that member set doesn't get out of sync with
gui1117 marked this conversation as resolved.
Show resolved Hide resolved
/// other logic managing the member set.
///
/// # <weight>
/// ## Weight
/// - `O(MP + N)` where:
Expand Down