Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[WIP] Turn on the logger's interest cache #10072

Closed
wants to merge 2 commits into from

Conversation

koute
Copy link
Contributor

@koute koute commented Oct 21, 2021

This lowers the CPU overhead of our logging machinery when any trace log is enabled down to ~3% of what it was originally.

After this PR lands we should also reenable log reloading, as this should make it essentially free.

DO NOT YET MERGE. This is a WIP since we still need to wait until a new version of tracing-log is actually released on crates.io.

@koute koute added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 21, 2021
@stale
Copy link

stale bot commented Nov 20, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Nov 20, 2021
@stale stale bot closed this Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant