Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

GRANDPA: Proper equivocation handling and misbehavior reporting. #1112

Closed
rphmeier opened this issue Nov 14, 2018 · 4 comments
Closed

GRANDPA: Proper equivocation handling and misbehavior reporting. #1112

rphmeier opened this issue Nov 14, 2018 · 4 comments
Labels
I2-security The client fails to follow expected, security-sensitive, behaviour.
Milestone
Polkadot

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Nov 14, 2018 •
edited
Loading

On the runtime side: Alter the srml-grandpa module to check signatures on grandpa messages and integrate with consensus/slashing on this misbehavior.

Depends on paritytech/finality-grandpa#26

On the node side, craft, sign, and queue equivocation-report transactions when the finality_grandpa::Environment methods for prevote_equivocation and precommit_equivocation are called.

related: #1065
@rphmeier rphmeier changed the title GRANDPA: Proper equivocation handling GRANDPA: Proper equivocation handling and misbehavior reporting. Nov 14, 2018
@rphmeier
Copy link
Contributor Author

rphmeier commented Nov 16, 2018 •
edited
Loading

(srml-grandpa is currently not implemented except in the rh-grandpa-chain branch: #1128)

@gavofyork gavofyork added I2-security The client fails to follow expected, security-sensitive, behaviour. and removed F5-task labels Dec 18, 2018
@gavofyork gavofyork added this to the 1.0 (final) milestone Dec 18, 2018
@rphmeier rphmeier mentioned this issue Mar 27, 2019
Closed
@marcio-diaz marcio-diaz self-assigned this Apr 8, 2019
@marcio-diaz marcio-diaz removed their assignment Oct 23, 2019
@gavofyork gavofyork modified the milestones: 1.1, 3.0 Nov 28, 2019
@philipstanislaus
Copy link
Contributor

philipstanislaus commented Feb 26, 2020 •
edited
Loading

@rphmeier is this still an issue? Trying to determine if there are any red flags to launching Centrifuge's mainnet shortly. Thanks!

@HCastano
Copy link
Contributor

@philipstanislaus Equivocation handling is being worked on in #3868.

@andresilva
Copy link
Contributor

Fixed in #3868.

lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@NikVolf
Update substrate, add block construction metrics (paritytech#1112)
8566d31 
* add metrics

* reset & update

* update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I2-security The client fails to follow expected, security-sensitive, behaviour.
Projects
None yet
Milestone
Polkadot
Development

No branches or pull requests
6 participants
@andresilva @gavofyork @marcio-diaz @philipstanislaus @rphmeier @HCastano