Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RuntimeUpdated digest item #1146

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Add a RuntimeUpdated digest item #1146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4e7a3d
Add a RuntimeUpdated digest item
tomaka Aug 18, 2021
da03b62
Rename
tomaka Sep 15, 2021
0b8789c
Merge branch 'main' into runtime-updated
mergify[bot] Sep 15, 2021
a5951fb
Merge branch 'main' into runtime-updated
mergify[bot] Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,9 @@ impl<'a> DigestRef<'a> {
babe_seal_index = Some(item_num);
}
DigestItem::BabeSeal(_) => return Err(Error::SealIsntLastItem),
DigestItem::ChangesTrieSignal(_) | DigestItem::Beefy { .. } => {}
DigestItem::ChangesTrieSignal(_)
| DigestItem::Beefy { .. }
| DigestItem::RuntimeEnvironmentUpdated => {}
}
}

Expand Down Expand Up @@ -693,7 +695,9 @@ impl<'a> DigestRef<'a> {
babe_seal_index = Some(item_num);
}
DigestItemRef::BabeSeal(_) => return Err(Error::SealIsntLastItem),
DigestItemRef::ChangesTrieSignal(_) | DigestItemRef::Beefy { .. } => {}
DigestItemRef::ChangesTrieSignal(_)
| DigestItemRef::Beefy { .. }
| DigestItemRef::RuntimeEnvironmentUpdated => {}
}
}

Expand Down Expand Up @@ -918,6 +922,10 @@ pub enum DigestItemRef<'a> {
/// Smoldot doesn't interpret the content of the log item at the moment.
opaque: &'a [u8],
},

/// Runtime of the chain has been updated in this block. This can include the runtime code or
/// the heap pages.
RuntimeEnvironmentUpdated,
}

impl<'a> DigestItemRef<'a> {
Expand Down Expand Up @@ -1051,6 +1059,7 @@ impl<'a> DigestItemRef<'a> {
ret.extend_from_slice(opaque);
iter::once(ret)
}
DigestItemRef::RuntimeEnvironmentUpdated => iter::once(vec![8]),
}
}
}
Expand All @@ -1068,6 +1077,7 @@ impl<'a> From<&'a DigestItem> for DigestItemRef<'a> {
DigestItem::ChangesTrieRoot(v) => DigestItemRef::ChangesTrieRoot(v),
DigestItem::ChangesTrieSignal(v) => DigestItemRef::ChangesTrieSignal(v.clone()),
DigestItem::Beefy { opaque } => DigestItemRef::Beefy { opaque: &*opaque },
DigestItem::RuntimeEnvironmentUpdated => DigestItemRef::RuntimeEnvironmentUpdated,
}
}
}
Expand Down Expand Up @@ -1095,6 +1105,10 @@ pub enum DigestItem {
/// Smoldot doesn't interpret the content of the log item at the moment.
opaque: Vec<u8>,
},

/// Runtime of the chain has been updated in this block. This can include the runtime code or
/// the heap pages.
RuntimeEnvironmentUpdated,
}

impl<'a> From<DigestItemRef<'a>> for DigestItem {
Expand All @@ -1120,6 +1134,7 @@ impl<'a> From<DigestItemRef<'a>> for DigestItem {
DigestItemRef::Beefy { opaque } => DigestItem::Beefy {
opaque: opaque.to_vec(),
},
DigestItemRef::RuntimeEnvironmentUpdated => DigestItem::RuntimeEnvironmentUpdated,
}
}
}
Expand Down Expand Up @@ -1205,6 +1220,7 @@ fn decode_item(mut slice: &[u8]) -> Result<(DigestItemRef, &[u8]), Error> {
.map_err(|_| Error::DigestItemDecodeError)?;
Ok((DigestItemRef::ChangesTrieSignal(item), slice))
}
8 => Ok((DigestItemRef::RuntimeEnvironmentUpdated, slice)),
ty => Err(Error::UnknownDigestLogType(ty)),
}
}
Expand Down