This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Zombienet: test disputes with malus garbage candidates #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but paras should make progress Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
added
B0-silent
ordian
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Looks good, but I wonder how flaky this test will be.
Maybe we can reduce the number of parachains to 1 or 2, we don't need 7 for this test. It's also worth mentioning that we rely on suggest-garbage-candidate to back garbage candidate of others and we need at least 2 of them for backing to work.
zombienet_tests/functional/0003-parachains-garbage-candidate.feature
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrei Sandu <[email protected]>
Yeah, scaling it down makes it less flaky. |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
…/garbage_candidate_test
sandreim
force-pushed
the
sandreim/garbage_candidate_test
branch
from
e3c8fcc to
89b3197
Compare
pepoviola
approved these changes
Aug 11, 2022
ordian
reviewed
Aug 11, 2022
zombienet_tests/functional/0003-parachains-garbage-candidate.toml
Outdated
Show resolved
Hide resolved
zombienet_tests/functional/0003-parachains-garbage-candidate.toml
Outdated
Show resolved
Hide resolved
Co-authored-by: Andronik <[email protected]>
Co-authored-by: Andronik <[email protected]>
alvicsam
approved these changes
Aug 11, 2022
radupopa2010
approved these changes
Aug 11, 2022
sergejparity
approved these changes
Aug 11, 2022
coderobe
approved these changes
Aug 11, 2022
|
bot merge |
ordian
added a commit
that referenced
this pull request
Aug 15, 2022
* master: Transaction payment runtime apis: query call info and fee details (#5871) [ci] Improve cancel-pipeline job (#5874) Bump wasmtime from 0.38.1 to 0.38.3 (#5802) Incorporate changes from substrate PR #11908 (#5815) Add nomination pools to Polkadot runtime (#5582) Change request-response protocol names to include genesis hash & fork id (#5870) [ci] Run check-runtime only for PRs (#5858) Bump tokio from 1.18.2 to 1.19.2 (#5678) Zombienet: test disputes with malus garbage candidates (#5857) add unit tests to run runtime migrations (#5865) Trivial networking changes for Substrate PR #11940 (#5841) Renaming CLI prunning and keep-blocks flags (#5863) Update yamux to fix a potential crash (#5861)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces dangling PR #5020