Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Co #11206: Fix WASM block producer panic #5311

Closed
wants to merge 8 commits into from
Closed

Co #11206: Fix WASM block producer panic #5311

wants to merge 8 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Apr 12, 2022 •
edited
Loading

This is now just fixing a spelling mistake.
I think it makes sense to have this MR since the substrate companion would otherwise silently change the runtime.

Companion for paritytech/substrate#11206

ggwpez added 2 commits April 12, 2022 11:48
@ggwpez
Box events
e021a0f 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Add event size test
ea99f52 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 12, 2022
@ggwpez ggwpez self-assigned this Apr 12, 2022
@paritytech-ci paritytech-ci requested review from a team April 12, 2022 10:24
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 12, 2022
@ggwpez ggwpez mentioned this pull request Apr 12, 2022
Merged
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Apr 12, 2022
@ggwpez ggwpez changed the title Co #11206: Boxed events Co #11206: Fix WASM block producer panic Apr 13, 2022
@ggwpez ggwpez added C7-high ❗️ A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 13, 2022
@ggwpez ggwpez added C1-low PR touches the given topic and has a low impact on builders. and removed C7-high ❗️ labels Apr 13, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Apr 13, 2022

Closing now since it is not needed anymore since Im using a simpler approach.
The spell mistake can be fixed in another dedicated MR for that I think.

@ggwpez ggwpez closed this Apr 13, 2022
@ggwpez ggwpez deleted the oty-boxed-events branch September 6, 2022 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@svyatonik svyatonik Awaiting requested review from svyatonik

@acatangiu acatangiu Awaiting requested review from acatangiu

@antonio-dropulic antonio-dropulic Awaiting requested review from antonio-dropulic

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggwpez @bkchr