This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pvf-precheck: hook up runtime API #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
pepyakin
added
B0-silent
pepyakin
force-pushed
the
pep-pvf-runtime-api
branch
from
f9f0282 to
ec5b97b
Compare
pepyakin
force-pushed
the
pep-pvf-runtime-api
branch
from
ec5b97b to
5d62280
Compare
This commit hooks up the API provided by #4457 to the runtime API subsystem. In a following PR this API will be consumed by the PVF pre-checking subsystem. Co-authored-by: Chris Sosnin <[email protected]>
pepyakin
force-pushed
the
pep-pvf-runtime-api
branch
from
5d62280 to
1e86546
Compare
eskimor
approved these changes
Dec 20, 2021
| @@ -1054,6 +1055,12 @@ sp_api::decl_runtime_apis! { | |||
|
|
|||
| /// Scrape dispute relevant from on-chain, backing votes and resolved disputes. | |||
| fn on_chain_votes() -> Option<ScrapedOnChainVotes<H>>; | |||
|
|
|||
| /// Submits a PVF pre-checking statement into the transaction pool. | |||
| fn submit_pvf_check_statement(stmt: PvfCheckStatement, signature: ValidatorSignature); | |||
There was a problem hiding this comment.
Other kind of statements we imported via inherents. How come we are using the transaction pool here?
There was a problem hiding this comment.
It was suggested by Rob here. We never really discussed exactly this part, mostly because I agree with this. On one hand, we can afford routing those through the chain: we do not expect a lot of those and they are not too heavy. On the other hand, it greatly simplifies the whole construction. The next PR is for subsystem and you'll see how simple it is.
That being said, in future we can reconsider and implement it via a network protocol if such need arises.
There was a problem hiding this comment.
Not sure, I fully understand this - maybe a quick call tomorrow?
|
bot merge |
|
Error: Checks failed for 1e86546 |
pepyakin
added a commit
that referenced
this pull request
Dec 27, 2021
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
This commit hooks up the API provided by #4457 to the runtime API subsystem. In a following PR this API will be consumed by the PVF pre-checking subsystem. Co-authored-by: Chris Sosnin <[email protected]> Co-authored-by: Chris Sosnin <[email protected]>
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
This commit hooks up the API provided by paritytech#4457 to the runtime API subsystem. In a following PR this API will be consumed by the PVF pre-checking subsystem. Co-authored-by: Chris Sosnin <[email protected]> Co-authored-by: Chris Sosnin <[email protected]>
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
This commit incorporates the changes made to the runtime in the following PRs: - paritytech#4408 - paritytech#4457 - paritytech#4540 - paritytech#4542 - paritytech#4581 Note that this PR does not include the description of the PVF pre-checker subsystem. This should be addressed within paritytech#4611 Co-authored-by: sandreim <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit hooks up the API provided by #4457 to the runtime API
subsystem. In a following PR this API will be consumed by the PVF
pre-checking subsystem.
skip check-dependent-cumulus