This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add XCM pallet and config to Polkadot runtime #4313
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9b05af
xcm added
NachoPal fb99303
pull master
NachoPal 6235e51
xcm pallet & config added Polkadot
NachoPal 9199557
set advertise XCM version to 2 for Polkadot
apopiak aad17c6
remove ChildSystemParachainAsSuperuser from Polkadot XCM config
apopiak 3a5e075
remove unpaid execution for system parachains
apopiak 88bd947
remove unused imports
apopiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,9 +22,9 @@ | |
|
||
use pallet_transaction_payment::CurrencyAdapter; | ||
use runtime_common::{ | ||
auctions, claims, crowdloan, impls::DealWithFees, paras_registrar, slots, BlockHashCount, | ||
BlockLength, BlockWeights, CurrencyToVote, OffchainSolutionLengthLimit, | ||
OffchainSolutionWeightLimit, RocksDbWeight, SlowAdjustingFeeUpdate, | ||
auctions, claims, crowdloan, impls::DealWithFees, paras_registrar, slots, xcm_sender, | ||
BlockHashCount, BlockLength, BlockWeights, CurrencyToVote, OffchainSolutionLengthLimit, | ||
OffchainSolutionWeightLimit, RocksDbWeight, SlowAdjustingFeeUpdate, ToAuthor, | ||
}; | ||
|
||
use runtime_parachains::{ | ||
|
@@ -39,8 +39,11 @@ use runtime_parachains::{ | |
use authority_discovery_primitives::AuthorityId as AuthorityDiscoveryId; | ||
use beefy_primitives::crypto::AuthorityId as BeefyId; | ||
use frame_support::{ | ||
construct_runtime, parameter_types, | ||
traits::{Contains, KeyOwnerProofSystem, LockIdentifier, OnRuntimeUpgrade, PrivilegeCmp}, | ||
construct_runtime, match_type, parameter_types, | ||
traits::{ | ||
Contains, Everything, InstanceFilter, KeyOwnerProofSystem, LockIdentifier, Nothing, | ||
OnRuntimeUpgrade, PrivilegeCmp, | ||
}, | ||
weights::Weight, | ||
PalletId, RuntimeDebug, | ||
}; | ||
|
@@ -78,6 +81,16 @@ use sp_std::{cmp::Ordering, collections::btree_map::BTreeMap, prelude::*}; | |
use sp_version::NativeVersion; | ||
use sp_version::RuntimeVersion; | ||
use static_assertions::const_assert; | ||
use xcm::latest::prelude::*; | ||
use xcm_builder::{ | ||
AccountId32Aliases, AllowKnownQueryResponses, AllowSubscriptionsFrom, | ||
AllowTopLevelPaidExecutionFrom, AllowUnpaidExecutionFrom, BackingToPlurality, | ||
ChildParachainAsNative, ChildParachainConvertsVia, ChildSystemParachainAsSuperuser, | ||
CurrencyAdapter as XcmCurrencyAdapter, FixedWeightBounds, IsChildSystemParachain, IsConcrete, | ||
LocationInverter, SignedAccountId32AsNative, SignedToAccountId32, SovereignSignedViaLocation, | ||
TakeWeightCredit, UsingComponents, | ||
}; | ||
use xcm_executor::XcmExecutor; | ||
|
||
pub use pallet_balances::Call as BalancesCall; | ||
pub use pallet_election_provider_multi_phase::Call as EPMCall; | ||
|
@@ -90,7 +103,6 @@ pub use sp_runtime::BuildStorage; | |
/// Constant values used within the runtime. | ||
pub mod constants; | ||
use constants::{currency::*, fee::*, time::*}; | ||
use frame_support::traits::InstanceFilter; | ||
|
||
// Weights used in the runtime. | ||
mod weights; | ||
|
@@ -173,7 +185,8 @@ impl Contains<Call> for BaseFilter { | |
Call::Registrar(_) | | ||
Call::Auctions(_) | | ||
Call::Crowdloan(_) | | ||
Call::BagsList(_) => true, | ||
Call::BagsList(_) | | ||
Call::XcmPallet(_) => true, | ||
// All pallets are allowed, but exhaustive match is defensive | ||
// in the case of adding new pallets. | ||
} | ||
|
@@ -1280,6 +1293,157 @@ impl auctions::Config for Runtime { | |
type WeightInfo = weights::runtime_common_auctions::WeightInfo<Runtime>; | ||
} | ||
|
||
parameter_types! { | ||
/// The location of the DOT token, from the context of this chain. Since this token is native to this | ||
/// chain, we make it synonymous with it and thus it is the `Here` location, which means "equivalent to | ||
/// the context". | ||
pub const DotLocation: MultiLocation = Here.into(); | ||
/// The Polkadot network ID. This is named. | ||
pub const PolkadotNetwork: NetworkId = NetworkId::Polkadot; | ||
/// Our XCM location ancestry - i.e. what, if anything, `Parent` means evaluated in our context. Since | ||
/// Polkadot is a top-level relay-chain, there is no ancestry. | ||
pub const Ancestry: MultiLocation = Here.into(); | ||
/// The check account, which holds any native assets that have been teleported out and not back in (yet). | ||
pub CheckAccount: AccountId = XcmPallet::check_account(); | ||
} | ||
|
||
/// The canonical means of converting a `MultiLocation` into an `AccountId`, used when we want to determine | ||
/// the sovereign account controlled by a location. | ||
pub type SovereignAccountOf = ( | ||
// We can convert a child parachain using the standard `AccountId` conversion. | ||
ChildParachainConvertsVia<ParaId, AccountId>, | ||
// We can directly alias an `AccountId32` into a local account. | ||
AccountId32Aliases<PolkadotNetwork, AccountId>, | ||
); | ||
|
||
/// Our asset transactor. This is what allows us to interest with the runtime facilities from the point of | ||
/// view of XCM-only concepts like `MultiLocation` and `MultiAsset`. | ||
/// | ||
/// Ours is only aware of the Balances pallet, which is mapped to `DotLocation`. | ||
pub type LocalAssetTransactor = XcmCurrencyAdapter< | ||
// Use this currency: | ||
Balances, | ||
// Use this currency when it is a fungible asset matching the given location or name: | ||
IsConcrete<DotLocation>, | ||
// We can convert the MultiLocations with our converter above: | ||
SovereignAccountOf, | ||
// Our chain's account ID type (we can't get away without mentioning it explicitly): | ||
AccountId, | ||
// We track our teleports in/out to keep total issuance correct. | ||
CheckAccount, | ||
>; | ||
|
||
/// The means that we convert an the XCM message origin location into a local dispatch origin. | ||
type LocalOriginConverter = ( | ||
// A `Signed` origin of the sovereign account that the original location controls. | ||
SovereignSignedViaLocation<SovereignAccountOf, Origin>, | ||
// A child parachain, natively expressed, has the `Parachain` origin. | ||
ChildParachainAsNative<parachains_origin::Origin, Origin>, | ||
// The AccountId32 location type can be expressed natively as a `Signed` origin. | ||
SignedAccountId32AsNative<PolkadotNetwork, Origin>, | ||
// A system child parachain, expressed as a Superuser, converts to the `Root` origin. | ||
ChildSystemParachainAsSuperuser<ParaId, Origin>, | ||
apopiak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
); | ||
|
||
parameter_types! { | ||
/// The amount of weight an XCM operation takes. This is a safe overestimate. | ||
pub const BaseXcmWeight: Weight = 1_000_000_000; | ||
/// Maximum number of instructions in a single XCM fragment. A sanity check against weight | ||
/// calculations getting too crazy. | ||
pub const MaxInstructions: u32 = 100; | ||
} | ||
|
||
/// The XCM router. When we want to send an XCM message, we use this type. It amalgamates all of our | ||
/// individual routers. | ||
pub type XcmRouter = ( | ||
// Only one router so far - use DMP to communicate with child parachains. | ||
xcm_sender::ChildParachainRouter<Runtime, XcmPallet>, | ||
); | ||
|
||
parameter_types! { | ||
pub const Polkadot: MultiAssetFilter = Wild(AllOf { fun: WildFungible, id: Concrete(DotLocation::get()) }); | ||
pub const PolkadotForStatemint: (MultiAssetFilter, MultiLocation) = (Polkadot::get(), Parachain(1000).into()); | ||
} | ||
pub type TrustedTeleporters = (xcm_builder::Case<PolkadotForStatemint>,); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @joepetrowski this addresses #4289 |
||
|
||
match_type! { | ||
pub type OnlyParachains: impl Contains<MultiLocation> = { | ||
MultiLocation { parents: 0, interior: X1(Parachain(_)) } | ||
}; | ||
} | ||
|
||
/// The barriers one of which must be passed for an XCM message to be executed. | ||
pub type Barrier = ( | ||
// Weight that is paid for may be consumed. | ||
TakeWeightCredit, | ||
// If the message is one that immediately attemps to pay for execution, then allow it. | ||
AllowTopLevelPaidExecutionFrom<Everything>, | ||
// Messages coming from system parachains need not pay for execution. | ||
AllowUnpaidExecutionFrom<IsChildSystemParachain<ParaId>>, | ||
// Expected responses are OK. | ||
AllowKnownQueryResponses<XcmPallet>, | ||
// Subscriptions for version tracking are OK. | ||
AllowSubscriptionsFrom<OnlyParachains>, | ||
); | ||
|
||
pub struct XcmConfig; | ||
impl xcm_executor::Config for XcmConfig { | ||
type Call = Call; | ||
type XcmSender = XcmRouter; | ||
type AssetTransactor = LocalAssetTransactor; | ||
type OriginConverter = LocalOriginConverter; | ||
type IsReserve = (); | ||
type IsTeleporter = TrustedTeleporters; | ||
type LocationInverter = LocationInverter<Ancestry>; | ||
type Barrier = Barrier; | ||
type Weigher = FixedWeightBounds<BaseXcmWeight, Call, MaxInstructions>; | ||
// The weight trader piggybacks on the existing transaction-fee conversion logic. | ||
type Trader = UsingComponents<WeightToFee, DotLocation, AccountId, Balances, ToAuthor<Runtime>>; | ||
type ResponseHandler = XcmPallet; | ||
type AssetTrap = XcmPallet; | ||
type AssetClaims = XcmPallet; | ||
type SubscriptionService = XcmPallet; | ||
} | ||
|
||
parameter_types! { | ||
pub const CouncilBodyId: BodyId = BodyId::Executive; | ||
// We are conservative with the XCM version we advertize. | ||
pub const AdvertisedXcmVersion: u32 = 2; | ||
} | ||
|
||
/// Type to convert an `Origin` type value into a `MultiLocation` value which represents an interior location | ||
/// of this chain. | ||
pub type LocalOriginToLocation = ( | ||
// We allow an origin from the Collective pallet to be used in XCM as a corresponding Plurality of the | ||
// `Unit` body. | ||
BackingToPlurality< | ||
Origin, | ||
pallet_collective::Origin<Runtime, CouncilCollective>, | ||
CouncilBodyId, | ||
>, | ||
// And a usual Signed origin to be used in XCM as a corresponding AccountId32 | ||
SignedToAccountId32<Origin, AccountId, PolkadotNetwork>, | ||
); | ||
|
||
impl pallet_xcm::Config for Runtime { | ||
type Event = Event; | ||
type SendXcmOrigin = xcm_builder::EnsureXcmOrigin<Origin, LocalOriginToLocation>; | ||
type XcmRouter = XcmRouter; | ||
// Anyone can execute XCM messages locally... | ||
type ExecuteXcmOrigin = xcm_builder::EnsureXcmOrigin<Origin, LocalOriginToLocation>; | ||
// ...but they must match our filter, which rejects all. | ||
type XcmExecuteFilter = Nothing; | ||
type XcmExecutor = XcmExecutor<XcmConfig>; | ||
type XcmTeleportFilter = Everything; | ||
apopiak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type XcmReserveTransferFilter = Everything; | ||
type Weigher = FixedWeightBounds<BaseXcmWeight, Call, MaxInstructions>; | ||
type LocationInverter = LocationInverter<Ancestry>; | ||
type Origin = Origin; | ||
type Call = Call; | ||
const VERSION_DISCOVERY_QUEUE_SIZE: u32 = 100; | ||
type AdvertisedXcmVersion = AdvertisedXcmVersion; | ||
} | ||
|
||
construct_runtime! { | ||
pub enum Runtime where | ||
Block = Block, | ||
|
@@ -1363,6 +1527,9 @@ construct_runtime! { | |
Slots: slots::{Pallet, Call, Storage, Event<T>} = 71, | ||
Auctions: auctions::{Pallet, Call, Storage, Event<T>} = 72, | ||
Crowdloan: crowdloan::{Pallet, Call, Storage, Event<T>} = 73, | ||
|
||
// Pallet for sending XCM. | ||
XcmPallet: pallet_xcm::{Pallet, Call, Storage, Event<T>, Origin, Config} = 99, | ||
} | ||
} | ||
|
||
|
@@ -1905,6 +2072,7 @@ mod test_fees { | |
MaxNominatorRewardedPerValidator::get(), | ||
) as f64; | ||
let block_weight = BlockWeights::get().max_block as f64; | ||
|
||
println!( | ||
"a full payout takes {:.2} of the block weight [{} / {}]", | ||
payout_weight / block_weight, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab or spaces, this is the question