Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Tweaks to XCM for Benchmarking #4283

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Tweaks to XCM for Benchmarking #4283

merged 3 commits into from
Nov 15, 2021

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Nov 15, 2021 •
edited
Loading

This PR extracts minor refactorings used in #3940.

The only logical change happening here is the introduction of is_subscribed API to the XCM versioning handler.

  • Moved TestSubscriptionService and TestAssetTrap into a test_utils file so it can be reused.
  • Moved logic after xcm::execute to xcm::post_execute so that it can be triggered manually.
  • Added is_subscribed to XCM Version Subscribtion API

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 15, 2021
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Nov 15, 2021
apopiak
apopiak reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick drive-by comment 😅

xcm/xcm-executor/src/lib.rs Show resolved Hide resolved
@shawntabrizi shawntabrizi requested a review from apopiak November 15, 2021 18:18
apopiak
apopiak approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawntabrizi
Copy link
Member Author

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for 413379a

@shawntabrizi
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f26005b into master Nov 15, 2021
@paritytech-processbot paritytech-processbot bot deleted the shawntabrizi-xcm-tweaks branch November 15, 2021 21:38
girazoki pushed a commit to moonbeam-foundation/polkadot that referenced this pull request Nov 16, 2021
@shawntabrizi @girazoki
Tweaks to XCM for Benchmarking (paritytech#4283)
c3b98df 
* tweaks to xcm stuff for benchmarking

* Update xcm/xcm-executor/src/lib.rs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apopiak apopiak apopiak approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawntabrizi @KiChjang @apopiak