This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add an overview of Validity subsystems #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the file at this new location included changes not present in w3f/research#87, this is effectively a rebase, applied manually. I believe that I have successfully retained all of, and only, the intended changes.
|
It looks like @coriolinus signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
coriolinus
commented
May 27, 2020
|
@coriolinus Did you want this to be pleasereview or in-progress? You will want to change the label to inprogress if so |
rphmeier
reviewed
May 30, 2020
rphmeier
reviewed
May 30, 2020
rphmeier
reviewed
May 30, 2020
rphmeier
reviewed
May 30, 2020
coriolinus
added
A3-in_progress
I think it makes most sense to track and review the subsystems overview in a different PR than the one which adds content to the implementor's guide.
coriolinus
added
A0-please_review
|
I think this is ready for review. I've isolated the changes to the implementer's guide; I'm going to open a new PR shortly which contains those changes, and does not contain the subsystems overview. |
coriolinus
changed the title
coriolinus
added a commit
that referenced
this pull request
Jun 2, 2020
The subsystems overview in #1161 is a very useful reference for what subsystems need to talk to each other, when, and why; it helps us design the actual messages. However, administratively, it belongs in a different PR. This commit brings in all the changes made there so far as a base for an independent PR.
rphmeier
changed the title
|
(Validity Module is about secondary checking & post-inclusion reporting, this is more complex and will be done later) |
rphmeier
reviewed
Jun 2, 2020
|
|
||
| ## Misbehavior Arbitration | ||
|
|
||
| The misbehavior arbitration subsystem kicks in when two validator nodes disagree about a candidate's validity. In this case, _all_ validators, not just those assigned to its parachain, weigh in on the validity of this candidate. The minority is slashed. |
There was a problem hiding this comment.
There seem to be two disparate cases covered here.
- Arbitration of blocks that are included in the chain, where disputes are signaled by the chain. These blocks are guaranteed to be available, and arbitration is handled by having validators self-select based on a random process to do further approval checks. This is handled on the runtime side by the
Validitymodule. - Arbitration of blocks that have not been included in the chain. My PR to the validity module Add exception to overseer communication and write up local and remote disputes #1176 discusses the possibility of "remote" disputes, for blocks that haven't been included in this chain. We could allow that any disagreement becomes a remote dispute, but so far I've only considered the possibility of remote disputes where a candidate is potentially backed (i.e. has a majority of support from its validator group).
Either way, I'd classify both of these as beyond scope for this PR and suggest that we not define what to do with conflicting votes at the backing stage of the pipeline and revisit those definitions in its own PR, along with the rest of the self-selection logic. This logic is most likely to span multiple subsystems, including those for availability.
There was a problem hiding this comment.
I didn't intend to include case 1 in this; the cases I've been thinking of are all for blocks which have not yet been included. That said, I'm fine leaving the behavior of this subsystem mostly unspecified for now pending future work.
coriolinus
added
the
B0-silent
coriolinus
changed the title
rphmeier
approved these changes
Jun 4, 2020
rphmeier
added a commit
that referenced
this pull request
Jun 10, 2020
…rview (#1185) * expand subsystems descriptions independent of subsystems overview The subsystems overview in #1161 is a very useful reference for what subsystems need to talk to each other, when, and why; it helps us design the actual messages. However, administratively, it belongs in a different PR. This commit brings in all the changes made there so far as a base for an independent PR. * Reorder subsystem descriptions, add some messages Update ordering of subsystem descriptions to rough order of use, mirroring the order in the overview document. Added some message types. Added OverseerSignal variants to several types, such that each subsystem only needs to listen for a single type. * add some more message types, Statement Distribution overview * add more detail on Statement Distribution, Misbehavior Arbitration * intentionally punt MA details for a future PR * reduce duplication from overseer signal handling * reword for clarity * clarify: other modules and subsystems also get to talk to the network * finish current work on candidate selection * update candidate backing subsystem description according to current thought * update mechanism for candidate backing to report collator misbehavior to candidate selection * sketch out the peer receipt state machine * Fix typo in roadmap/implementors-guide/guide.md Co-authored-by: Robert Habermeier <[email protected]> * Don't specify 'peer validators', as messages from non-validator peers are ignored regardless * clarify instancing of peer receipt state machine * add section on peer knowledge tracking * fix typo in roadmap/implementors-guide/guide.md Co-authored-by: Max Inden <[email protected]> Co-authored-by: Robert Habermeier <[email protected]> Co-authored-by: Max Inden <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over from w3f/research#87.
Enumerate the set of subsystems in the validity module and briefly describe their high-level responsibilities and the graph of messages between them.