Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #6205 #6238

Merged
merged 7 commits into from
Nov 5, 2024
Merged

[stable2407] Backport #6205 #6238

merged 7 commits into from
Nov 5, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #6205 into stable2407 from bkchr.

See the documentation on how to use this bot.

@bkchr @github-actions
pallet-message-queue: Fix max message size calculation (#6205)
8f2a499 
The max size of a message should not depend on the weight left in a
given execution context. Instead the max message size depends on the
service weights configured for the pallet. A message that may does not
fit into `on_idle` is not automatically overweight, because it may can
be executed successfully in `on_initialize` or in another block in
`on_idle` when there is more weight left.

---------

Co-authored-by: GitHub Action <[email protected]>
(cherry picked from commit 5d7181c)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot requested a review from a team as a code owner October 25, 2024 13:47
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Oct 25, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Oct 25, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

ggwpez
ggwpez previously approved these changes Oct 25, 2024
View reviewed changes
@ggwpez
Fix unrelated test
2dca661 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 25, 2024 15:49
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7645282

@ggwpez
Fix unrelated test
42fbb02 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
acatangiu
acatangiu previously approved these changes Oct 28, 2024
View reviewed changes
@ggwpez
Fix more tests
04ffb0e 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez requested review from athei and a team as code owners October 28, 2024 09:55
@ermalkaleci ermalkaleci mentioned this pull request Oct 28, 2024
Merged
@bkchr
Copy link
Member

bkchr commented Nov 5, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 5, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7699644 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 31-6a91bb27-aa37-4311-a7a7-e12433478f31 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci requested a review from koute as a code owner November 5, 2024 12:47
@command-bot
Copy link

command-bot bot commented Nov 5, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7699644 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7699644/artifacts/download.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 5, 2024 12:48
@bkchr bkchr merged commit 6d6aa61 into stable2407 Nov 5, 2024
11 of 16 checks passed
@bkchr bkchr deleted the backport-6205-to-stable2407 branch November 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu left review comments

@ggwpez ggwpez ggwpez left review comments

@athei athei Awaiting requested review from athei athei is a code owner

@koute koute Awaiting requested review from koute

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paritytech-cicd-pr @bkchr @ggwpez @acatangiu