Added Trusted Query API calls #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3c41a
commented
Oct 14, 2024
x3c41a
commented
Oct 15, 2024
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
x3c41a
changed the title
x3c41a
changed the title
x3c41a
changed the title
acatangiu
approved these changes
Oct 17, 2024
| @@ -1797,6 +1797,15 @@ impl_runtime_apis! { | |||
| genesis_config_presets::preset_names() | |||
| } | |||
| } | |||
|
|
|||
| impl xcm_runtime_apis::trusted_query::TrustedQueryApi<Block> for Runtime { | |||
| fn is_trusted_reserve(asset: VersionedAsset, location: VersionedLocation) -> Result<bool, xcm_runtime_apis::trusted_query::Error> { | |||
There was a problem hiding this comment.
You can define a
type XcmTrustedQueryResult = Result<bool, xcm_runtime_apis::trusted_query::Error>;at the top level of files like this on so then the runtime apis have shorter/more-readable signature:
Suggested change
| fn is_trusted_reserve(asset: VersionedAsset, location: VersionedLocation) -> Result<bool, xcm_runtime_apis::trusted_query::Error> { | |
| fn is_trusted_reserve(asset: VersionedAsset, location: VersionedLocation) -> XcmTrustedQueryResult { |
Comment on lines
28
to
29
| /// # Arguments | ||
| /// |
There was a problem hiding this comment.
nit
Suggested change
| /// # Arguments | |
| /// | |
| /// # Arguments: |
Comment on lines
35
to
36
| /// # Arguments | ||
| /// |
There was a problem hiding this comment.
nit
Suggested change
| /// # Arguments | |
| /// | |
| /// # Arguments: |
acatangiu
reviewed
Oct 18, 2024
There was a problem hiding this comment.
@x3c41a this suggestion applied to all runtimes, not just one.
Also I see you merged the PR with some junk binary files added after the reviews, please ASAP open a PR to remove them...
This was referenced Oct 18, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Those files were introduced by mistake in #6039
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Changed returned type of API methods from `Result<bool, xcm_runtime_apis::trusted_query::Error>` to a typed one `type XcmTrustedQueryResult = Result<bool, xcm_runtime_apis::trusted_query::Error>;` Follow-up of [PR-6039](#6039) --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
…hains (paritytech#6212) Added missing API methods to Rococo and Westend parachains. Preparatory work for making chopstick tests run smoothly. Follow-up of [PR#6039](paritytech#6039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented is_trusted_reserve and is_trusted_teleporter API methods.
Tested them with regular and chopstick tests.
Fixes #97