Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getters from pallet-membership #4840

Merged
merged 13 commits into from
Jul 1, 2024
Merged

Remove getters from pallet-membership #4840

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fdf160c
Add prdoc
PolkadotDom Jun 19, 2024
3317749
to turbo
PolkadotDom Jun 19, 2024
eb2bd9a
Remove members getter
PolkadotDom Jun 19, 2024
0a1885d
Remove members getter cont'd
PolkadotDom Jun 19, 2024
fcb8558
Remove prime getter
PolkadotDom Jun 19, 2024
a674bc1
Membership fmt
PolkadotDom Jun 19, 2024
469b3ed
Reimplement getters and relegate bump to minor
PolkadotDom Jun 22, 2024
69a818b
Merge branch 'master' into dom/remove-getters-pallet-membership
PolkadotDom Jun 22, 2024
bf1618c
Add documentation to new getters
PolkadotDom Jun 24, 2024
dd3357b
Merge branch 'master' into dom/remove-getters-pallet-membership
PolkadotDom Jun 24, 2024
7d6443c
Conform to documentation rules
PolkadotDom Jun 28, 2024
06ee44f
Conform to documentation rules
PolkadotDom Jun 28, 2024
a27b7db
Merge branch 'master' into dom/remove-getters-pallet-membership
kianenigma Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions prdoc/pr_4840.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Removed `pallet::getter` usage from pallet-membership

doc:
- audience: Runtime Dev
description: |
This PR removed the `pallet::getter`s from `pallet-membership`.
The syntax `StorageItem::<T, I>::get()` should be used instead.

crates:
- name: pallet-membership
bump: minor
PolkadotDom marked this conversation as resolved.
Show resolved Hide resolved
Loading
Loading