[subsystem-bench] Trigger own assignments in approval-voting #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
approved these changes
Jun 12, 2024
| keystore | ||
| .sr25519_generate_new( | ||
| ASSIGNMENT_KEY_TYPE_ID, | ||
| Some(state.test_authorities.key_seeds.first().unwrap().as_str()), |
There was a problem hiding this comment.
Nit: state.test_authorithies.key_seeds.get(NODE_UNDER_TEST) to make it future proof.
No, that's for the keystore we use for generating the messages for all other nodes in the network, the change here is the keystore that we provide to approval-voting when we instantiate it. |
AndreiEres
added
R0-silent
|
The CI pipeline was cancelled due to failure one of the required jobs. |
sandreim
approved these changes
Jun 24, 2024
alexggh
added a commit
that referenced
this pull request
Jul 17, 2024
Since #4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Since #4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…h#5042) Since paritytech#4772, the benchamrks triggers its own assignments, but the mocks weren't properly hooked up, so that the approval is sent as well, so they would have counted as no-shows and impact the time it takes for a block to be approved. Fixed by adding mocks for availability recovery and candidate-validation and hook those into the benchmark. Signed-off-by: Alexandru Gheorghe <[email protected]>
This was referenced Aug 21, 2024
alexggh
added a commit
that referenced
this pull request
Aug 27, 2024
The accepted divergence rate of 1/1000 is execesive and leads to false positives especially after #4772 and #5042, so let's increase it to 1/100 since we do have some randomness in the system and there is no point in being that strict. Signed-off-by: Alexandru Gheorghe <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
The accepted divergence rate of 1/1000 is excessive and leads to false positives especially after #4772 and #5042, so let's increase it to 1/100 since we do have some randomness in the system and there is no point in being that strict. Fixes: #5463 --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.