Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage preparations #4387

Merged
merged 12 commits into from
May 7, 2024
Merged

Code coverage preparations #4387

merged 12 commits into from
May 7, 2024

Conversation

AndWeHaveAPlan
Copy link
Contributor

@AndWeHaveAPlan AndWeHaveAPlan commented May 6, 2024

Added manual jobs for code coverage (triggered via codecov-start job):

  • codecov-start - initialize Codecov report for commit/pr
  • test-linux-stable-codecov - perform nextest run and upload coverage data parts
  • codecov-finish - finalize uploading of data parts and generate Codecov report

Coverage requires code to be built with -C instrument-coverage which causes build errors (e .g. error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` , seems like related to 2641) and unstable tests behavior (example). This is where we'll nee the developers assistance

closing [polkadot-sdk] Add code coverage #902

@AndWeHaveAPlan AndWeHaveAPlan added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes and removed A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@29c8130). Click here to learn what that means.

❗ Current head 22e4f5b differs from pull request most recent head 5919aee. Consider uploading reports for the commit 5919aee to get more accurate results

Additional details and impacted files

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c8130...5919aee. Read the comment docs.

@AndWeHaveAPlan AndWeHaveAPlan marked this pull request as ready for review May 6, 2024 16:27
@AndWeHaveAPlan AndWeHaveAPlan requested a review from a team as a code owner May 6, 2024 16:27
@AndWeHaveAPlan AndWeHaveAPlan changed the title Code coverage base Code coverage preparations May 6, 2024
@AndWeHaveAPlan AndWeHaveAPlan requested a review from a team as a code owner May 7, 2024 13:39
@AndWeHaveAPlan AndWeHaveAPlan added this pull request to the merge queue May 7, 2024
@alvicsam alvicsam mentioned this pull request May 7, 2024
Merged via the queue into master with commit 1c8595a May 7, 2024
145 of 146 checks passed
@AndWeHaveAPlan AndWeHaveAPlan deleted the es/coverage branch May 7, 2024 15:41
paritytech-ci pushed a commit that referenced this pull request May 8, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job):
 - **codecov-start** - initialize Codecov report for commit/pr
- **test-linux-stable-codecov** - perform `nextest run` and upload
coverage data parts
- **codecov-finish** - finalize uploading of data parts and generate
Codecov report

Coverage requires code to be built with `-C instrument-coverage` which
causes build errors (e .g. ```error[E0275]: overflow evaluating the
requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```,
seems like related to
[2641](#2641)) and
unstable tests behavior
([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)).
This is where we'll nee the developers assistance

closing [[polkadot-sdk] Add code coverage
#902](paritytech/ci_cd#902)
@pierreaubert
Copy link

I looked at https://app.codecov.io/gh/paritytech/polkadot-sdk. Is it correct that we only have 5% coverage? that looks unlikely.

hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job):
 - **codecov-start** - initialize Codecov report for commit/pr
- **test-linux-stable-codecov** - perform `nextest run` and upload
coverage data parts
- **codecov-finish** - finalize uploading of data parts and generate
Codecov report

Coverage requires code to be built with `-C instrument-coverage` which
causes build errors (e .g. ```error[E0275]: overflow evaluating the
requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```,
seems like related to
[2641](paritytech#2641)) and
unstable tests behavior
([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)).
This is where we'll nee the developers assistance

closing [[polkadot-sdk] Add code coverage
paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job):
 - **codecov-start** - initialize Codecov report for commit/pr
- **test-linux-stable-codecov** - perform `nextest run` and upload
coverage data parts
- **codecov-finish** - finalize uploading of data parts and generate
Codecov report

Coverage requires code to be built with `-C instrument-coverage` which
causes build errors (e .g. ```error[E0275]: overflow evaluating the
requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```,
seems like related to
[2641](paritytech#2641)) and
unstable tests behavior
([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)).
This is where we'll nee the developers assistance

closing [[polkadot-sdk] Add code coverage
paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants