-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage preparations #4387
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filesContinue to review full report in Codecov by Sentry.
|
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage #902](paritytech/ci_cd#902)
I looked at https://app.codecov.io/gh/paritytech/polkadot-sdk. Is it correct that we only have 5% coverage? that looks unlikely. |
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](paritytech#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](paritytech#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
Added manual jobs for code coverage (triggered via
codecov-start
job):nextest run
and upload coverage data partsCoverage requires code to be built with
-C instrument-coverage
which causes build errors (e .g.error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\`
, seems like related to 2641) and unstable tests behavior (example). This is where we'll nee the developers assistanceclosing [polkadot-sdk] Add code coverage #902