Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate experimental feature #3654

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

Totally removes the experimental feature. Closes #3648.

@s0me0ne-unkn0wn s0me0ne-unkn0wn added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Mar 12, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn requested a review from a team as a code owner March 12, 2024 09:44
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5499179

@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2024

I think this should get a prdoc, since it does change the default behaviour of many crates for downstream users.

@s0me0ne-unkn0wn s0me0ne-unkn0wn removed the R0-silent Changes should not be mentioned in any release notes label Mar 16, 2024
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

prdoc/pr_3654.prdoc Outdated Show resolved Hide resolved
@bkchr bkchr enabled auto-merge March 17, 2024 19:28
@bkchr bkchr added this pull request to the merge queue Mar 17, 2024
Merged via the queue into master with commit 1f9505c Mar 17, 2024
124 of 130 checks passed
@bkchr bkchr deleted the s0me0ne/remove-experimental-feature branch March 17, 2024 20:24
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
Totally removes the `experimental` feature. Closes paritytech#3648.

---------

Co-authored-by: Bastian Köcher <[email protected]>
@Morganamilo Morganamilo mentioned this pull request Apr 4, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate experimental feature
5 participants