Fix misleading comment about RewardHandler in epm config #3095
Conversation
|
Previously the gear team was investigating why the total supply was increasing when theoretically it shouldn't (gear-tech/gear#3389) It turned out the newly minted tokens went to some staking-miner operator, contrary to our initial assumption that it would do "nothing upon rewards". |
|
This pull request doesn't make any sense. This should be documented in the pallet. Like in the docs it says how this pallet works. In general the logic of just creating the fees by increasing the total insurance looks weird to me. |
|
Basically this changes the inflation. @gpestana is this really what we want? |
|
For context, the decision to "mint" the rewards that are paid out to the staking miner was intentional at the time. The amount is usually small, and it is in the same category as the amount that is minted to be paid out to validators. It is a good idea to provide a way now configure this, such that one option is to mint, and another is to (try to) transfer them from a known account, eg. The treasury. |
|
A part of the issue here is also that |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
In pallet_election_provider_multi_phase::Config, the effect of
type RewardHandler = ()
is to mint rewards from the void, not "nothing to do upon rewards"
btwiuse
force-pushed
the
fix-misleading-comment-about-rewardhandler
branch
from
b64b228
to
69dae6c
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
240b374
…3095) In pallet_election_provider_multi_phase::Config, the effect of type RewardHandler = () is to mint rewards from the void, not "nothing to do upon rewards" Co-authored-by: navigaid <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
* master: (27 commits) Bridges improved tests and nits (#5128) Fix misleading comment about RewardHandler in epm config (#3095) Introduce a workflow updating the wishlist leaderboards (#5085) membership: Restructure pallet into separate files (#4536) Fix after ring-proof api change (#5126) Bump paritytech/review-bot from 2.4.0 to 2.5.0 (#5057) Bump docker/login-action from 3.0.0 to 3.3.0 (#5109) Bump docker/build-push-action from 5.1.0 to 6.5.0 (#5108) Bump peter-evans/create-pull-request from 5.0.0 to 6.1.0 (#5093) Tx Payment: drop ED requirements for tx payments with exchangeable asset (#4488) Remove `pallet-getter` usage from pallet-transaction-payment (#4970) pallet macro: do not generate try-runtime related code when frame-support doesn't have try-runtime. (#5099) fix(chain-spec): ChainSpecBuilder with object as default genesis (#4345) Migrate BEEFY BLS crypto to bls12-381 curve (#4931) Bump clap from 4.5.9 to 4.5.10 in the known_good_semver group (#5120) Use jobserver in wasm-builder to limit concurrency of spawned cargo processes (#4946) include events for voting (#4613) [subsystem-bench] Add mocks for own assignments triggering (#5042) Remove not-audited warning (#5114) hotfix: blockchain/backend: Skip genesis leaf to unblock syncing (#5103) ...
In pallet_election_provider_multi_phase::Config, the effect of
is to mint rewards from the void, not "nothing to do upon rewards"