Contracts build risc-v fixtures #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
force-pushed
the
pg/riscv-fixtures
branch
from
6091bba to
9975e91
Compare
pgherveou
added
the
R0-silent
athei
reviewed
Nov 30, 2023
|
We should be able to pass CI now. Toolchain should be installed for both macOS and Linux. |
Nice will merge master and try to pass these jobs |
…kadot-sdk into pg/riscv-fixtures
…kadot-sdk into pg/riscv-fixtures
athei
reviewed
Jan 4, 2024
substrate/frame/contracts/fixtures/build/riscv_memory_layout.ld
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Removed it already, (the tmp hack of checking in the rv compilation output). We only use caching to check if we need to recompile a given fixture now |
|
Yes my bad. I just read "cache" and thought it was about this. But it is just to prevent re-building all fixtures when only one of them changed. Good to be merged once the CI is green. |
ascjones
approved these changes
Jan 4, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Follow up from paritytech#2347 this time to verify that fixtures build to RISC-V --------- Co-authored-by: alvicsam <[email protected]> Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2347 this time to verify that fixtures build to RISC-V