Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes path issue in derive-impl #1823

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Fixes path issue in derive-impl #1823

merged 10 commits into from
Oct 11, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Oct 9, 2023

Needs sam0x17/macro_magic#13

The associated PR allows the export of tokens from macro_magic at the specified path. This fixes the path issue in derive-impl. Now, we can import the default config using the standard rust syntax:

use frame_system::config_preludes::TestDefaultConfig;

[derive_impl(TestDefaultConfig as frame_system::DefaultConfig)]
impl frame_system::DefaultConfig for Test {
   //....
}

@gupnik gupnik added R0-silent Changes should not be mentioned in any release notes I2-bug The node fails to follow expected behavior. T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Oct 9, 2023
@gupnik gupnik requested review from a team October 9, 2023 06:14
sam0x17
sam0x17 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once macro_magic pr is fixed + merged + published

@gupnik gupnik enabled auto-merge (squash) October 11, 2023 04:41
@gupnik gupnik merged commit 294e998 into master Oct 11, 2023
8 checks passed
@gupnik gupnik deleted the gupnik/derive-impl-fix branch October 11, 2023 05:26
ordian added a commit that referenced this pull request Oct 12, 2023
@ordian
Merge branch 'master' into ao-disabling-statement-distribution
e333fa8 
* master: (33 commits)
  ci: set CI_IMAGE back to (now updated) .ci-unified (#1854)
  ci: bump ci image to rust 1.73.0 (#1830)
  Refactor Identity to benchmark v2 (#1838)
  PVF worker: bump landlock, update ABI docs (#1850)
  Xcm emulator nits (#1649)
  Fixes path issue in derive-impl (#1823)
  upgrade to macro_magic 0.4.3 (#1832)
  Use safe math when pruning statuses (#1835)
  remote-ext: fix state download stall on slow connections and reduce memory usage (#1295)
  Update testnet bootnode dns name (#1712)
  [FRAME] Warn on unchecked weight witness (#1818)
  [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726)
  Update bridges subtree (#1803)
  Check for parent of first ready block being on chain (#1812)
  Make CheckNonce refuse transactions signed by accounts with no providers (#1578)
  Fix Asset Hub collator crashing when starting from genesis (#1788)
  Mixnet integration (#1346)
  [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458)
  Treasury spends various asset kinds (#1333)
  chore: bump zombienter version (#1806)
  ...
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@gupnik
Fixes path issue in derive-impl (paritytech#1823)
4e50ba5 
Needs sam0x17/macro_magic#13

The associated PR allows the export of tokens from macro_magic at the
specified path. This fixes the path issue in derive-impl. Now, we can
import the default config using the standard rust syntax:

```rust
use frame_system::config_preludes::TestDefaultConfig;

[derive_impl(TestDefaultConfig as frame_system::DefaultConfig)]
impl frame_system::DefaultConfig for Test {
   //....
}
```
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
90bc29a
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
a9985c0
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
0d3d597
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
f8c1f3e
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
a767c2f
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
72d12ce
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
36f548f
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
6cb2966
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
6fa85b8
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
0c1f511
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
f5278e9
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
a6aaa96
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
6ea6769
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
ea3f115
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@serban300
Use named parameters for indirect calls (paritytech#1823)
8cd3653
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@serban300 @bkchr
Use named parameters for indirect calls (#1823)
5d875d0
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre left review comments

@juangirini juangirini juangirini approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I2-bug The node fails to follow expected behavior. R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. T10-tests This PR/Issue is related to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gupnik @sam0x17 @juangirini @franciscoaguirre