Pallet Lottery migrate to Fungibles traits #1810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
nuke-web3
added
A1-insubstantial
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
Stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #226
This pallet used
type Currency: ReservableCurrency<Self::AccountId>;but in the logic, no reservation/hold logic existed, or exists in now. Thus we now only use a simpletype Currency: fungible::Balanced<Self::AccountId> + fungible::Mutate<Self::AccountId>;to manage the lottery's pot.We know of no downstream runtimes that are somehow able to place reservations/holds/locks/... on the
T::PalletId::get().into_account_truncating()account for the pot, nor is any accounting changes at all in this pallet, so no migrations are needed at all in this PR. There are no braking changes whatsoever here.