-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sudo/sessionKeys: Implement sudo_sessionKeys_unstable_generate #1682
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks good to me :)
@lexnv what is the status here? |
I believe I put this on hold for the new Since this PR is already spec-ed out and will add it as If that sounds like a plan, I'll polish this up a bit and ask for some reviews soon 🙏 |
Okay 👍 Yeah I will finish the mentioned pr soon. |
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
This PR implements the sudo_sessionKeys_unstable_generate method.
This is basically an equivalent for the
rotate_keys
API in the RPC-Spec-V2 with extended ability to provide a user-defined seed.The RPC method calls into
SessionKeys_generate_session_keys
runtime function.Then, the
SessionKeys_generate_session_keys
runtime function generates a series of keys,inserts those keys into the keystore, and returns all the public keys concatenated.
Added a test to validate that keys are propagated to the keystone.
This PR does not expose the
sudo_sessionKeys_unstable_generate
to the RPC layer yet, since there might be changes wrt the naming convention.Part of #1516.
@paritytech/subxt-team