Make the node version independent of the crate version #1495
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
There was a problem hiding this comment.
Qs: we will version manually now? Is there a context for this change?
Overall it looks really good - now we won't get a node/worker version mismatch between releases (during development). Workers should still get rebuilt on every commit so breakages should be rare, but we just won't enforce that, which is fine for most dev. So this addresses the discussion at #626 nicely.
| @@ -33,7 +33,7 @@ use tokio::{io, net::UnixStream, runtime::Runtime}; | |||
| /// spawning the desired worker. | |||
| #[macro_export] | |||
| macro_rules! decl_worker_main { | |||
| ($expected_command:expr, $entrypoint:expr, $worker_version:expr) => { | |||
| ($expected_command:expr, $entrypoint:expr, $worker_version:expr $(,)*) => { | |||
| /// | ||
| /// The worker binaries associated to the node binary should ensure that they are using the same | ||
| /// version as the main node that started them. | ||
| pub const NODE_VERSION: &'static str = "1.1.0"; |
There was a problem hiding this comment.
Why not env!("CARGO_PKG_VERSION")?
There was a problem hiding this comment.
I mean, okay, we don't want to use the commit hash in node version, but why the node version should be independent from the crate version in the first place?
There was a problem hiding this comment.
Because crates.io semver works differently to how we version our nodes.
|
If we're doing this, we can probably also remove
|
We already have done versioning manually (when we speak about the node version). The context is that crates.io semver is different to how we version our node. For now we will bump every major version of every crate for putting it onto crates.io, but the node version should not follow these bumps. |
|
@paritytech/release-engineering you will then need to change this |
Add logic to check if the `BUILD_RELEASE_VERSION` tag is available in docker registry, if not calculate the previous version to use as secondary image. This fix the issue in test using the `secondary image` and bumping the `NODE_VERSION`. (e.g #1495)
ghost
mentioned this pull request
* Setup deps * Remove Koi from account migration test * paritytech/polkadot-sdk#1495 * Bump * paritytech/polkadot-sdk#1524 * !! paritytech/polkadot-sdk#1363 * paritytech/polkadot-sdk#1492 * paritytech/polkadot-sdk#1911 * paritytech/polkadot-sdk#1900 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1661 * paritytech/polkadot-sdk#2144 * paritytech/polkadot-sdk#2048 * paritytech/polkadot-sdk#1672 * paritytech/polkadot-sdk#2303 * paritytech/polkadot-sdk#1256 * Remove identity and vesting * Fixes * paritytech/polkadot-sdk#2657 * paritytech/polkadot-sdk#1313 * paritytech/polkadot-sdk#2331 * paritytech/polkadot-sdk#2409 part.1 * paritytech/polkadot-sdk#2767 * paritytech/polkadot-sdk#2521 Signed-off-by: Xavier Lau <[email protected]> * paritytech/polkadot-sdk#1222 * paritytech/polkadot-sdk#1234 part.1 * Satisfy compiler * XCM V4 part.1 * paritytech/polkadot-sdk#1246 * Remove pallet-democracy part.1 * paritytech/polkadot-sdk#2142 * paritytech/polkadot-sdk#2428 * paritytech/polkadot-sdk#3228 * XCM V4 part.2 * Bump * Build all runtimes * Build node * Remove pallet-democracy Signed-off-by: Xavier Lau <[email protected]> * Format * Fix pallet tests * Fix precompile tests * Format * Fixes * Async, remove council, common pallet config * Fix `ethtx-forward` test case (#1519) * Fix ethtx-forward tests * Format * Fix following the review * Fixes * Fixes * Use default impl * Benchmark helper * Bench part.1 * Bench part.2 * Bench part.3 * Fix all tests * Typo * Feat * Fix EVM tracing build * Reuse upstream `proof_size_base_cost()` (#1521) * Format issue * Fixes * Fix CI --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Bear Wang <[email protected]>
No description provided.