New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PRdoc check #1419

Merged

chevdor merged 1 commit into master from wk-230906-fix-prdoc-ci

Sep 6, 2023

Contributor

chevdor commented Sep 6, 2023

This PR fixes a big in the GH workflow: it removes a hard-coded value and uses the real PR number 🤦


          Fix PRdoc check

175b98b

chevdor added the R0-silent label

chevdor requested review from a team

September 6, 2023 10:39

chevdor enabled auto-merge (squash)

September 6, 2023 10:39

coderobe approved these changes

View reviewed changes

ggwpez approved these changes

View reviewed changes

Member

ggwpez left a comment

One Q so that i understand what is happening:

There has been a CI check added that enforces changelogs for each merge request?
Could you please announce this in the forum or somewhere? Otherwise i see people not getting it 🙈

chevdor merged commit 50de035 into master

11 checks passed

chevdor deleted the wk-230906-fix-prdoc-ci branch

September 6, 2023 11:58

Contributor Author

chevdor commented Sep 6, 2023

Yes, indeed, that could help :)

Let me bring the information together in the forum: https://forum.parity.io/t/pr-documentation-prdoc/2065
That should address all your quesions.

I keep it internal for now, I can publish to the external forum once the dust settles down and the schema is considered stable.

ordian added a commit that referenced this pull request


          Merge branch 'master' into ao-try-fixing-zombienet-slashing

27f8a62

* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...

ordian added a commit that referenced this pull request


          Merge branch 'master' into ao-polkadot-use-pinning-api

* master: (28 commits)
  Adds base benchmark for do_tick in broker pallet (#1235)
  zombienet: use another collator image for the slashing test (#1386)
  Prevent a fail prdoc check to block (#1433)
  Fix nothing scheduled on session boundary (#1403)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  ...

Ank4n pushed a commit that referenced this pull request


          Fix PRdoc check (#1419)

a317ef9

Daanvdplas pushed a commit that referenced this pull request


          Fix PRdoc check (#1419)

kiltbot mentioned this pull request

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

c32242a

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

20e2a06

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

c1136e9

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

416d4e4

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

b2569c4

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

414cc10

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

294103d

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

14e1f3d

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

3193a29

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

1ede5a3

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

fde1af4

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

7dd452b

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

0225ceb

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

ac25307

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

502d2c2

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

7d9888d

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

63e8470

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

2b6f06b

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

f9d17bd

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

5c1da27

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

d8b25cc

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

20c3bbd

…vered, then we must select para header that may be proved using this relay header (paritytech#1419)

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Follow-up on paritytech#1419 (paritytech#1531)

d2e70d6

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

bkchr pushed a commit that referenced this pull request


          fixed on-demand parachains relay case: if better relay header is deli…

0a3f8ac

…vered, then we must select para header that may be proved using this relay header (#1419)

bkchr pushed a commit that referenced this pull request


          Follow-up on #1419 (#1531)

77af92b

* Parachains source cosmetic changes

- Make `ParaHashAtSource` more generic
- Modify `on_chain_parachain_header` to return `HeaderId`
- Shortening variable names

Signed-off-by: Serban Iorga <[email protected]>

* Change ParachainsSource::max_head_id type

Change ParachainsSource::max_head_id to Arc<Mutex<NoopOption>>

Signed-off-by: Serban Iorga <[email protected]>

* code review changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels