-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Protocol
and Notifications
#516
Comments
@melekes This could be a good task to get familiar with the networking code. Some of the tasks can be done as independent PRs |
I just realized that we can't trust |
and treat it instead as any other `Notifications` protocol Refs #13542
After paritytech/substrate#12828,
Protocol
has no role in the networking stack anymore as the syncing protocol now lives abovesc-network
and the low-level API used for sync is no longer used. Notification-related events can be sent directly fromNotifications
.Tasks:
HARDCODED_PEERSET_SYNC
and all functionality that references the hardcodedPeerset
entryadd_peers_to_set
anddisconnect_peer
forNotifications
block_announce_config
fromParams
insrc/config.rs
and treat it instead as any otherNotifications
protocol[1] "By coincidence", paritytech/substrate#12441 converted the default empty handshake to send the role of the node as the default handshake. This means that each protocol now has the capability of learning the role of remote peer by decoding the handshake, meaning that this logic can be moved out of
Protocol
and theBlockAnnouncesHandshake
decoding can also moved toSyncingEngine
.The text was updated successfully, but these errors were encountered: