Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offchain http: upgrade hyper to v1 #4896

Closed
niklasad1 opened this issue Jun 27, 2024 · 0 comments · Fixed by #5919
Closed

offchain http: upgrade hyper to v1 #4896

niklasad1 opened this issue Jun 27, 2024 · 0 comments · Fixed by #5919
Labels
I4-refactor Code needs refactoring.

Comments

@niklasad1
Copy link
Member

niklasad1 commented Jun 27, 2024 •
edited
Loading

Ideally, substrate shouldn't use two different versions of hyper.

There is one thing that is blocking it which isn't trivial to fix in the offchain http depends on low-level body stuff that isn't exposed anymore and needs to re-written.

Code such as this doesn't work anymore because that Body and APIs around has been removed....
@bkchr bkchr added the I4-refactor Code needs refactoring. label Jun 27, 2024
This was referenced Oct 3, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2024
@ShoyuVanilla
substrate-offchain: upgrade hyper to v1 (#5919)
5a14285 
Closes #4896
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@ShoyuVanilla @mordamax
substrate-offchain: upgrade hyper to v1 (paritytech#5919)
c7f3a9e 
Closes paritytech#4896
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@ShoyuVanilla @mordamax
substrate-offchain: upgrade hyper to v1 (paritytech#5919)
d3f9220 
Closes paritytech#4896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I4-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
2 participants
@bkchr @niklasad1