Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate usage of xcm::v4 #4297

Closed
bkontur opened this issue Apr 25, 2024 · 1 comment · Fixed by #4355
Closed

Investigate usage of xcm::v4 #4297

bkontur opened this issue Apr 25, 2024 · 1 comment · Fixed by #4355
Assignees
@bkontur

Comments

@bkontur
Copy link
Contributor

bkontur commented Apr 25, 2024

I found two cases for investigation:

for coretime stuff

  • I think we should change to v4 to lastest to avoid unnecessary problems when adding v5
use xcm::v4::{send_xcm, Instruction, Junction, Location, OriginKind, SendXcm, WeightLimit, Xcm};

for query_acceptable_payment_assets

  • if !matches!(xcm_version, 3 | 4) or Ok([VersionedAssetId::V4(, I think we should use also VersionedAssetId::from for latest
@bkontur bkontur moved this to Todo in Bridges + XCM Apr 25, 2024
@seadanda
Copy link
Contributor

There should be no issues replacing this on the coretime side

@bkontur bkontur moved this from Todo to In Progress in Bridges + XCM May 2, 2024
@bkontur bkontur self-assigned this May 2, 2024
@bkontur bkontur mentioned this issue May 2, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue May 2, 2024
@bkontur
More xcm::v4 cleanup and `xcm_fee_payment_runtime_api::XcmPaymentAp…
30a1972 
…i` nits (#4355)

This PR:
- changes `xcm::v4` to `xcm::prelude` imports for coretime stuff
- changes `query_acceptable_payment_assets` /
`query_weight_to_asset_fee` implementations to be more resilient to the
XCM version change
- adds `xcm_fee_payment_runtime_api::XcmPaymentApi` to the
AssetHubRococo/Westend exposing a native token as acceptable payment
asset

Continuation of: #3607

Closes: #4297

## Possible follow-ups

- [ ] add all sufficient assets (`Assets`, `ForeignAssets`) as
acceptable payment assets ?
@github-project-automation github-project-automation bot moved this from In Progress to Done in Bridges + XCM May 2, 2024
fgamundi pushed a commit to moondance-labs/polkadot-sdk that referenced this issue Jul 17, 2024
@bkontur @fgamundi
More xcm::v4 cleanup and `xcm_fee_payment_runtime_api::XcmPaymentAp…
bcb332c 
…i` nits (paritytech#4355)

This PR:
- changes `xcm::v4` to `xcm::prelude` imports for coretime stuff
- changes `query_acceptable_payment_assets` /
`query_weight_to_asset_fee` implementations to be more resilient to the
XCM version change
- adds `xcm_fee_payment_runtime_api::XcmPaymentApi` to the
AssetHubRococo/Westend exposing a native token as acceptable payment
asset

Continuation of: paritytech#3607

Closes: paritytech#4297

## Possible follow-ups

- [ ] add all sufficient assets (`Assets`, `ForeignAssets`) as
acceptable payment assets ?
fgamundi pushed a commit to moondance-labs/polkadot-sdk that referenced this issue Jul 17, 2024
@bkontur @fgamundi
More xcm::v4 cleanup and `xcm_fee_payment_runtime_api::XcmPaymentAp…
3b313a8 
…i` nits (paritytech#4355)

This PR:
- changes `xcm::v4` to `xcm::prelude` imports for coretime stuff
- changes `query_acceptable_payment_assets` /
`query_weight_to_asset_fee` implementations to be more resilient to the
XCM version change
- adds `xcm_fee_payment_runtime_api::XcmPaymentApi` to the
AssetHubRococo/Westend exposing a native token as acceptable payment
asset

Continuation of: paritytech#3607

Closes: paritytech#4297

## Possible follow-ups

- [ ] add all sufficient assets (`Assets`, `ForeignAssets`) as
acceptable payment assets ?
girazoki pushed a commit to moondance-labs/polkadot-sdk that referenced this issue Aug 1, 2024
@bkontur @girazoki
More xcm::v4 cleanup and `xcm_fee_payment_runtime_api::XcmPaymentAp…
b03e03f 
…i` nits (paritytech#4355)

This PR:
- changes `xcm::v4` to `xcm::prelude` imports for coretime stuff
- changes `query_acceptable_payment_assets` /
`query_weight_to_asset_fee` implementations to be more resilient to the
XCM version change
- adds `xcm_fee_payment_runtime_api::XcmPaymentApi` to the
AssetHubRococo/Westend exposing a native token as acceptable payment
asset

Continuation of: paritytech#3607

Closes: paritytech#4297

## Possible follow-ups

- [ ] add all sufficient assets (`Assets`, `ForeignAssets`) as
acceptable payment assets ?
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@bkontur @TarekkMA
More xcm::v4 cleanup and `xcm_fee_payment_runtime_api::XcmPaymentAp…
553dd7e 
…i` nits (paritytech#4355)

This PR:
- changes `xcm::v4` to `xcm::prelude` imports for coretime stuff
- changes `query_acceptable_payment_assets` /
`query_weight_to_asset_fee` implementations to be more resilient to the
XCM version change
- adds `xcm_fee_payment_runtime_api::XcmPaymentApi` to the
AssetHubRococo/Westend exposing a native token as acceptable payment
asset

Continuation of: paritytech#3607

Closes: paritytech#4297

## Possible follow-ups

- [ ] add all sufficient assets (`Assets`, `ForeignAssets`) as
acceptable payment assets ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkontur bkontur

Labels
None yet
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More xcm::v4 cleanup and xcm_fee_payment_runtime_api::XcmPaymentApi nits paritytech/polkadot-sdk
2 participants
@bkontur @seadanda