Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset conversion quote A->B can't be done in one call #1168

Open
gilescope opened this issue Aug 25, 2023 · 2 comments
Open

Asset conversion quote A->B can't be done in one call #1168

gilescope opened this issue Aug 25, 2023 · 2 comments
Labels
T2-pallets This PR/Issue is related to a particular pallet. T4-runtime_API This PR/Issue is related to runtime APIs.

Comments

@gilescope
Copy link
Contributor

The quote code currently quotes A -> native or native -> B,
but it would be less surprising if it could also answer A -> B quote requests.

https://github.com/paritytech/polkadot-sdk/blob/1a38d6d6be42b30e8be3ffccec75a4ec995fef9d/substrate/frame/asset-conversion/src/lib.rs#L1043C10-L1043C45

@gilescope gilescope added the T14-system_parachains This PR/Issue is related to system parachains. label Aug 25, 2023
@jsidorenko
Copy link
Contributor

We can simply put a path[] param instead of tokenA, tokenB, this would solve the issue and will have a similar interface to swap methods

@gilescope
Copy link
Contributor Author

gilescope commented Aug 26, 2023 via email

@joepetrowski joepetrowski added T2-pallets This PR/Issue is related to a particular pallet. T4-runtime_API This PR/Issue is related to runtime APIs. and removed T14-system_parachains This PR/Issue is related to system parachains. labels Aug 28, 2023
bkchr pushed a commit that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet. T4-runtime_API This PR/Issue is related to runtime APIs.
Projects
None yet
Development

No branches or pull requests

3 participants