Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to rust 2021 #298

Merged
merged 5 commits into from
Nov 21, 2021
Merged

move to rust 2021 #298

merged 5 commits into from
Nov 21, 2021

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Nov 14, 2021

Confirmed to build locally on Ubuntu 20.04.3 LTS:

rustc 1.56.1 (59eed8a2a 2021-11-01)
rustc 1.58.0-nightly (e90c5fbbc 2021-11-12)

@bkchr
Copy link
Member

bkchr commented Nov 14, 2021

@nukemandan you need to update the ui tests

rust-version = "1.56.1"
changelog
@nuke-web3
Copy link
Contributor Author

rust-version = "1.56.1" introduced

For reference, I tried to get this to cargo build with 1.56.0 and it failed with

error: package `...` cannot be built because it requires rustc 1.56.1 or newer, while the currently active rustc version is 1.56.0

With --ignore-rust-version it does build with 1.56.0, as expected.

@nuke-web3
Copy link
Contributor Author

bench-rust-nightly = cargo +nightly bench --features bit-vec,generic-array,derive throws a lot of build warnings, but passes. Also test reports like:

vec_decode_no_limit_u8/131072                                                                             
                        time:   [5.5258 us 5.5443 us 5.5708 us]
Found 12 outliers among 100 measurements (12.00%)
  4 (4.00%) high mild
  8 (8.00%) high severe

for example (running locally).

cargo +nightly miri test --features bit-vec,generic-array,arbitrary --release :

error: the 'miri' component which provides the command 'cargo-miri' is not available for the 'nightly-x86_64-unknown-linux-gnu' toolchain

I assume this is expected on an x86 machine? What does this run on 😅 ?

@nuke-web3
Copy link
Contributor Author

https://gitlab.parity.io/parity/parity-scale-codec/-/jobs/1235195

I see the env variables are somehow not getting picked up? I will try with TRYBUILD=overwrite and put in another commit to see if the next one is clean... It passes locally!

@bkchr bkchr merged commit ce09441 into master Nov 21, 2021
@bkchr bkchr deleted the ds/2021 branch November 21, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants