-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: pin geckodriver in wasm-pack tests #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through the linked tickets, and I see the pin to [email protected]
which I assume uses geckodriver 0.26 under the hood somewhere, but I'm not sure what to make of the rest of the changes. How is this related to chromedriver
which is now removed?
correct
|
I still don't get it, sorry! Did both chrome and gecko start to fail and with this PR we fix only gecko? Is there hope to fix chrome as well or are you saying it's impossible or not needed, or…? |
I didn't delete |
Now I finally get it. We have Thanks. |
exactly
We used to have it until it started to fail: #324. PRs to bring it back are welcome of course ;) |
rustwasm/wasm-pack#891
rustwasm/wasm-bindgen#2261