Polkadot Bulletin Chain client #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
commented
Sep 11, 2023
|
|
||
| /// Signed extension, used by Polkadot Bulletin. | ||
| #[derive(Encode, Decode, Debug, PartialEq, Eq, Clone, TypeInfo)] | ||
| pub struct SignedExtension(SignedExtensionSchema); |
There was a problem hiding this comment.
Had to add this custom struct, because this chain has no transaction payment signed extension.
serban300
reviewed
Sep 11, 2023
| #[derive(Encode, Decode, Debug, PartialEq, Eq, Clone, TypeInfo)] | ||
| pub struct SignedExtension(SignedExtensionSchema); | ||
|
|
||
| impl sp_runtime::traits::SignedExtension for SignedExtension { |
There was a problem hiding this comment.
Maybe we could have another trait something like SignedExtensionSchemaProvider {SignedExtensionSchema = ...} and implement sp_runtime::traits::SignedExtension automatically for the types that implement SignedExtensionSchemaProvider.
There was a problem hiding this comment.
That's a good idea, however it won't allow us to have a blanket implementation (I guess that is what you mean by "implement sp_runtime::traits::SignedExtension automatically", right?) of sp_runtime::traits::SignedExtension, because sp_runtime::traits::SignedExtension lives in the external crate (Substrate). And if we'll create some adapter for that, we won't be able to add custom methods which we need here (e.g. from_params and so on). I know - that looks ugly, but probably in the future we'll switch to something better (auto detecting well known signed extensions and explicitly asking about unknown on relayer start? something that we'll need to think of in #2491)
There was a problem hiding this comment.
Oh yes, you're right. I forgot about that.
serban300
approved these changes
Sep 12, 2023
svyatonik
added a commit
that referenced
this pull request
Sep 12, 2023
* relay-polkadot-bulletin-client * generate Polkadot Bulletin Chain Runtime
svyatonik
added a commit
that referenced
this pull request
Sep 19, 2023
* polkadot-staging for v1.0.0 * Add polkadot bulletin chain primitives (#2542) * add polkadot bulletin chain primitives * also impl ChainWithMessages * clippy * instead of requiring sp_std::vec::Vec import when using runtime API generation macro, let's use full type path directly in macro (#2551) * Polkadot Bulletin Chain client (#2552) * relay-polkadot-bulletin-client * generate Polkadot Bulletin Chain Runtime * Add relays that will be used in Polkadot Bulletin <> Polkadot.BH bridge (#2556) * added Polkadot.BH <> Polkadot Bulletin chain relays * uncommented ED stuff * complex PolkadotBulletin <> Polkadot.BH relay * removed TODO * spelling * prepare refund extension infra to add refund extension for messages from standalone chain (#2558) * prepare refund extension infra to add refund extension for messages from standalone chain * spelling * apply adapter to fix compilation * clippy * added POLKADOT_BULLETIN_CHAIN_ID constant * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain (#2566) * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain * clippy * fix compilation * fix codec dependency (#2567) * Support message relay limits override (#2570) * support message relay limits overrides for bridges * spelling * export EXTRA_STORAGE_PROOF_SIZE for Polkadot Bulletin (#2572)
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* polkadot-staging for v1.0.0 * Add polkadot bulletin chain primitives (paritytech#2542) * add polkadot bulletin chain primitives * also impl ChainWithMessages * clippy * instead of requiring sp_std::vec::Vec import when using runtime API generation macro, let's use full type path directly in macro (paritytech#2551) * Polkadot Bulletin Chain client (paritytech#2552) * relay-polkadot-bulletin-client * generate Polkadot Bulletin Chain Runtime * Add relays that will be used in Polkadot Bulletin <> Polkadot.BH bridge (paritytech#2556) * added Polkadot.BH <> Polkadot Bulletin chain relays * uncommented ED stuff * complex PolkadotBulletin <> Polkadot.BH relay * removed TODO * spelling * prepare refund extension infra to add refund extension for messages from standalone chain (paritytech#2558) * prepare refund extension infra to add refund extension for messages from standalone chain * spelling * apply adapter to fix compilation * clippy * added POLKADOT_BULLETIN_CHAIN_ID constant * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain (paritytech#2566) * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain * clippy * fix compilation * fix codec dependency (paritytech#2567) * Support message relay limits override (paritytech#2570) * support message relay limits overrides for bridges * spelling * export EXTRA_STORAGE_PROOF_SIZE for Polkadot Bulletin (paritytech#2572)
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* polkadot-staging for v1.0.0 * Add polkadot bulletin chain primitives (paritytech#2542) * add polkadot bulletin chain primitives * also impl ChainWithMessages * clippy * instead of requiring sp_std::vec::Vec import when using runtime API generation macro, let's use full type path directly in macro (paritytech#2551) * Polkadot Bulletin Chain client (paritytech#2552) * relay-polkadot-bulletin-client * generate Polkadot Bulletin Chain Runtime * Add relays that will be used in Polkadot Bulletin <> Polkadot.BH bridge (paritytech#2556) * added Polkadot.BH <> Polkadot Bulletin chain relays * uncommented ED stuff * complex PolkadotBulletin <> Polkadot.BH relay * removed TODO * spelling * prepare refund extension infra to add refund extension for messages from standalone chain (paritytech#2558) * prepare refund extension infra to add refund extension for messages from standalone chain * spelling * apply adapter to fix compilation * clippy * added POLKADOT_BULLETIN_CHAIN_ID constant * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain (paritytech#2566) * RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain * clippy * fix compilation * fix codec dependency (paritytech#2567) * Support message relay limits override (paritytech#2570) * support message relay limits overrides for bridges * spelling * export EXTRA_STORAGE_PROOF_SIZE for Polkadot Bulletin (paritytech#2572)
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* relay-polkadot-bulletin-client * generate Polkadot Bulletin Chain Runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2547