Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message sender origin (polkadot-staging) #2322

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Remove message sender origin (polkadot-staging) #2322

merged 1 commit into from
Aug 4, 2023

Conversation

svyatonik
Copy link
Contributor

#2318 (review)

No logic changes, so no audit required

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Aug 4, 2023
bkontur
bkontur approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkontur
Copy link
Contributor

bkontur commented Aug 4, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 4, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/parity-bridges-common/-/jobs/3332801 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/parity-bridges-common/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-8bccc735-dfec-4119-9f42-38cb765c91c2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 4, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/parity-bridges-common/-/jobs/3332801 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/parity-bridges-common/-/jobs/3332801/artifacts/download.

@svyatonik svyatonik merged commit 19f9c8f into polkadot-staging Aug 4, 2023
@svyatonik svyatonik deleted the remove-message-send-origin-from-polkadot-staging branch August 4, 2023 13:14
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
@svyatonik
remove message sender origin (paritytech#2322)
08ae6a7
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
@svyatonik
remove message sender origin (paritytech#2322)
0663212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

Assignees
No one assigned
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svyatonik @bkontur