Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily remove balance guard #2121

Merged
merged 1 commit into from
May 9, 2023
Merged

Temporarily remove balance guard #2121

merged 1 commit into from
May 9, 2023

Conversation

svyatonik
Copy link
Contributor

@svyatonik svyatonik commented May 9, 2023 •
edited
Loading

Three reasons:

  • it was disabled for complex relays, so it wasn't working for our case;
  • I'm currently working on refactoring client, and less code = easier review;
  • the code itself may be obsolete a bit - since we now have relayer "stakes", we may need to halt relayer when it gets slashed (to understand the reason of slash). Need to think about it (#2122)

@svyatonik svyatonik mentioned this pull request Aug 25, 2023
Closed
@svyatonik svyatonik merged commit 1c5fba8 into master May 9, 2023
@svyatonik svyatonik deleted the remove-balance-guard-temporarily branch May 9, 2023 08:43
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
@jsidorenko
Companion for #13158 (#2121)
f72ae2f 
* Companion for #13158

* Update values

* Add MaxAttributesPerCall

* Update weights

* Apply suggestions

* Fix imports

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: parity-processbot <>
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
@bkontur
BridgeHubRococo/Wococo nits + updated subtree (#2572)
e23be19 
* Nits (merge before separatelly)

* Small cosmetics for Rococo/Wococo bridge local run

* Squashed 'bridges/' changes from 04b3dda..5fc377a

5fc377a Support for kusama-polkadot relaying (#2128)
01f4b7f Fix clippy warnings (#2127)
696ff1c BHK/P alignments (#2115)
2a66aa3 Small fixes (#2126)
7810f1a Cosmetics (#2124)
daf250f Remove some `expect()` statements (#2123)
1c5fba8 temporarily remove balance guard (#2121)
3d0e547 Propagate message receival confirmation errors (#2116)
1c33143 Propagate message verification errors (#2114)
b075b00 Bump time from 0.3.20 to 0.3.21
51a3a51 Bump serde from 1.0.160 to 1.0.162
da88d04 Bump clap from 4.2.5 to 4.2.7
cdca322 Bump sysinfo from 0.28.4 to 0.29.0

git-subtree-dir: bridges
git-subtree-split: 5fc377a

* Fix

* Allow to change storage constants (DeliveryReward, RequiredStakeForStakeAndSlash) + tests

* Clippy

* New SA for RO/WO

* Squashed 'bridges/' changes from 5fc377a..0f6091d

0f6091d Bump polkadot/substrate (#2134)
9233f0a Bump tokio from 1.28.0 to 1.28.1
a29c1ca Bump serde from 1.0.162 to 1.0.163

git-subtree-dir: bridges
git-subtree-split: 0f6091d
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
@svyatonik
temporarily remove balance guard (paritytech#2121)
fc9e2e8
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
@svyatonik
temporarily remove balance guard (paritytech#2121)
ae06c73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serban300 serban300 serban300 approved these changes

Assignees
No one assigned
Labels
P-Relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svyatonik @serban300