Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcm in Rialto<>Millau bridge #1379

Merged
merged 16 commits into from
May 16, 2022
Merged

Xcm in Rialto<>Millau bridge #1379

merged 16 commits into from
May 16, 2022

Conversation

svyatonik
Copy link
Contributor

@svyatonik svyatonik commented Apr 27, 2022

What does this PR brings:

  1. XCM pallet is added to both Rialto and Millau;
  2. we're now able to send XCM between chains using send call of the XCM pallet. Hint: dest is MultiLocation { parents: 1, interior: X1(GlobalConsensus(Kusama)) } for Rialto -> Millau messages and MultiLocation { parents: 1, interior: X1(GlobalConsensus(Polkadot)) } for Millau -> Rialto;
  3. I haven't tried to send meaningful XCMs - just Trap(42), which just throws an error when dispatched. I'm more interested in seeing that the bridge delivers exactly what is sent. Even more, current routers will probably be dropped when we'll start wirking on bridge hub;
  4. I've removed InstantCurrencyPayments, since we're not going to use it anymore. When sending XCM using XCM pallet, the XCM engine is responsible for taking fees. The plan is to pay relayer rewards from the treasury (XCM v3 polkadot#4097 (comment)). But right now it is not handled, because we need to deal with that on bridge-hub parachain, which is missing now;
  5. fee for messages that are sent using messages pallet is not withdrawn from the sender account (so they're free). In the future, we'll close this option. It doesn't mean removal of the send_message call from the pallet - just blocking it in our test deployments (and on real deployments later).

@svyatonik svyatonik requested a review from a team as a code owner April 27, 2022 13:34
@svyatonik svyatonik removed the request for review from a team April 27, 2022 13:34
@svyatonik svyatonik marked this pull request as draft April 27, 2022 13:37
@svyatonik svyatonik requested a review from acatangiu May 12, 2022 10:17
@svyatonik svyatonik marked this pull request as ready for review May 12, 2022 10:17
@svyatonik svyatonik mentioned this pull request May 12, 2022
@svyatonik svyatonik merged commit 6d7a5ea into master May 16, 2022
@svyatonik svyatonik deleted the bridges-and-xcm branch May 16, 2022 08:46
Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good afaict 👍

jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Oct 27, 2022
jiguantong added a commit to darwinia-network/darwinia-parachain that referenced this pull request Oct 31, 2022
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Apr 12, 2023
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* add XCM pallet to Millau runtime

* some progress

* messages are delivered (no fee)

* temp

* flush

* flush

* some progress

* progress

* Trap(42) is dispatched successfully

* fix spelling

* no more manual sending

* parametrize weight credit for tests

* actually charge fees

* enable send-using-messages-pallet to keep our test deployments alive + send valid XCM sometimes

* fix benchmarks build

* fix tests
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* add XCM pallet to Millau runtime

* some progress

* messages are delivered (no fee)

* temp

* flush

* flush

* some progress

* progress

* Trap(42) is dispatched successfully

* fix spelling

* no more manual sending

* parametrize weight credit for tests

* actually charge fees

* enable send-using-messages-pallet to keep our test deployments alive + send valid XCM sometimes

* fix benchmarks build

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants