-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcm in Rialto<>Millau bridge #1379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ send valid XCM sometimes
Closed
acatangiu
reviewed
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good afaict 👍
10 tasks
jiguantong
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Oct 27, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Oct 31, 2022
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Apr 12, 2023
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* add XCM pallet to Millau runtime * some progress * messages are delivered (no fee) * temp * flush * flush * some progress * progress * Trap(42) is dispatched successfully * fix spelling * no more manual sending * parametrize weight credit for tests * actually charge fees * enable send-using-messages-pallet to keep our test deployments alive + send valid XCM sometimes * fix benchmarks build * fix tests
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* add XCM pallet to Millau runtime * some progress * messages are delivered (no fee) * temp * flush * flush * some progress * progress * Trap(42) is dispatched successfully * fix spelling * no more manual sending * parametrize weight credit for tests * actually charge fees * enable send-using-messages-pallet to keep our test deployments alive + send valid XCM sometimes * fix benchmarks build * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR brings:
send
call of the XCM pallet. Hint: dest isMultiLocation { parents: 1, interior: X1(GlobalConsensus(Kusama)) }
for Rialto -> Millau messages andMultiLocation { parents: 1, interior: X1(GlobalConsensus(Polkadot)) }
for Millau -> Rialto;Trap(42)
, which just throws an error when dispatched. I'm more interested in seeing that the bridge delivers exactly what is sent. Even more, current routers will probably be dropped when we'll start wirking on bridge hub;InstantCurrencyPayments
, since we're not going to use it anymore. When sending XCM using XCM pallet, the XCM engine is responsible for taking fees. The plan is to pay relayer rewards from the treasury (XCM v3 polkadot#4097 (comment)). But right now it is not handled, because we need to deal with that on bridge-hub parachain, which is missing now;send_message
call from the pallet - just blocking it in our test deployments (and on real deployments later).