Support non-standard fields in Response

[thebabush]

Hello,

I'm interacting with a server that sends additional fields in the response message. The fields contain data I care about, so I can't even simply patch jsonrpsee to ignore them (right now jsonerpsee just asserts due to unknown field).

I'm down to make a PR, but I'd like to know if you could guide me through the most painless way to implement this?

Seems like the easiest way would be to extend Response/Notification/etc to have some kind of unknowns: Value, but that would mean dynamic allocations + requiring a feature flag, which is ugly.

Thanks.

[niklasad1]

Hey hey,

I'm interacting with a server that sends additional fields in the response message. The fields contain data I care about, so I can't even simply patch jsonrpsee to ignore them (right now jsonerpsee just asserts due to unknown field).

Sorry about that I changed the deserialization of the responses to a manual implementation but forgot about that, fixed in #1353

I'm down to make a PR, but I'd like to know if you could guide me through the most painless way to implement this?

Seems like the easiest way would be to extend Response/Notification/etc to have some kind of unknowns: Value, but that would mean dynamic allocations + requiring a feature flag, which is ugly.

What we could is to introduce another field other: HashMap<String, serde_json::value::RawValue> where it's possible for folks to access custom stuff but kind of annoying allocate stuff that may not be used. We were discussing to hide it behind a feature flag but I'm not sure I tend to be reluctant to add more feature flags because it's so tricky to maintain etc.

Thus, I think it's fine to add to another field other: HashMap<String, serde_json::value::RawValue> to the response type.

[thebabush]

Thanks for replying.

Thus, I think it's fine to add to another field other: HashMap<String, serde_json::value::RawValue> to the response type.

Problem is RawValue is not sized. Would Value work?

Also, I want to get access to the fields, and process_single_response just returns the result. It doesn't seem too easy to change that.

[niklasad1]

Yeah, you could use either Box<RawValue> or serde_json::Value for that

[thebabush]

Well, here it is: thebabush@84130ec

However, that hashmap is useless atm.