Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

JoshOrndorff
Copy link
Contributor

This PR adds a client-side feature to the cumulus-primitives-parachain-inherent crate. Previously the client-side features were gated only with the std feature. This solution was not ideal because runtimes are also built to std, and when they are the entire client-side of this crate is built including its dependency on polkadot runtime which adds a lot of compile time.

With this new feature, we can express whether we want the client side or not without abusing the std feature.

@JoshOrndorff JoshOrndorff marked this pull request as draft October 27, 2021 21:13
@bkchr
Copy link
Member

bkchr commented Oct 28, 2021

This will not solve any problem that you have. When this feature is enabled somewhere in your workspace, it will always be enabled.

There will be coming changes in the near future (hopefully until the end of the year) which will remove the dependency on the polkadot-runtime in this case.

@bkchr bkchr closed this Oct 28, 2021
@JoshOrndorff
Copy link
Contributor Author

Can you share your idea for coming changes? Is there an issue with a description?

I was thinking last night that a primitives crate is supposed to be useable in the runtime and client side, whereas a client-side crate (think sc- crates in Substrate should contain the client side stuff. So it doesn't make that much sense for the client side stuff to live in the crate cumulus-primitives-parachain-inherent to have the client side stuff anyway.

@bkchr
Copy link
Member

bkchr commented Oct 28, 2021

#545

@bkchr
Copy link
Member

bkchr commented Oct 28, 2021

That is the issue that will fix your complain :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants