Add overhead benchmark to parachain-template

[kalaninja]

Adds benchmark overhead that was missing in the previous PR #1156

[ggwpez]

Is there a test to check that the new command works?
Fot the storage benchmark there seems to be one for the asset hubs:

cumulus/polkadot-parachain/tests/benchmark_storage_works.rs

Line 34 in 80aaed3

.args(["benchmark", "storage", "--chain", runtime])

[kalaninja]

Fot the storage benchmark there seems to be one for the asset hubs:

This test is from polkadot-parachain. I decided to split this into 2 PRs. So the overhead benchmark and the test for collator will come in a different PR.

Is there a test to check that the new command works?

I tested this one manually with cargo run -p parachain-template-node -- benchmark overhead

[kalaninja]

@ggwpez the test was added in #2900

[bkontur]

@kalaninja could we run benchbot here to see that it works? maybe for parachain-template it is not configured

[ggwpez]

@kalaninja could we run benchbot here to see that it works? maybe for parachain-template it is not configured

We can run it for the asset hubs over here once its merged and the bench bot is updated: #2900.
The Bot does not care about templates, since they dont need correct weights.

[ggwpez]

LGTM (tested it locally).

We could still add an integration test as good measure to ensure that we dont break it in the future, but its also fine like this 😄

[ggwpez]

Also here the Question; why not use the cfg! to make it look more compact instead of the cfg(not...?

[kalaninja]

the only reason is that it is done with attributes in all other places. So, just didn't want to mix multiple approaches.