This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
Mock epoch index and randomness in SproofBuilder (for testing) #1594
Merged
bkchr
merged 18 commits into
paritytech:master
from
4meta5:amar-mock-epoch-randomness-in-sproof
Sep 8, 2022
Merged
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c2595a8
minimal babe randomness in sproof builder
4meta5 d17c70c
fix indexing
4meta5 7a402da
fix index and clean comment
4meta5 b909024
use current para block for epoch and randomness
4meta5 49c6fd9
epoch is para block randomness is relay block
4meta5 ad213b2
fix
4meta5 4a884c8
Merge branch 'master' into amar-mock-epoch-randomness-in-sproof
4meta5 9b73ca4
make more configurable but keep defaults
4meta5 a4bb712
fix export
4meta5 5e0dae7
fix
4meta5 226d414
flatten
4meta5 6ce2233
better field names
4meta5 b5bc391
Update primitives/parachain-inherent/src/mock.rs
bkchr e6c10cb
Update primitives/parachain-inherent/src/mock.rs
bkchr 8d641e9
FMT
bkchr 815b51e
FIX
bkchr f1251eb
fmt
4meta5 890e900
Update primitives/parachain-inherent/src/mock.rs
4meta5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that part of the
RandomnessConfig
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default configuration updates the randomness whenever the epoch changes so I put them together, but now rethinking it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move the fields into
MockValidationDataInherentDataProvider
and get rid of this struct as that is preferred.